Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposure module #612

Closed
kindanduseful opened this issue Jan 5, 2019 · 11 comments
Closed

Exposure module #612

kindanduseful opened this issue Jan 5, 2019 · 11 comments
Labels
enhancement has-pull-request Issues which have a PR open module New Module idea new-feature

Comments

@kindanduseful
Copy link

Exposure is different from brightness -- not sure how! But a separate Exposure module would be nice, thank you!

@gitmate gitmate bot added the module New Module idea label Jan 5, 2019
@gitmate
Copy link

gitmate bot commented Jan 5, 2019

GitMate.io thinks the contributor most likely able to help you is @jywarren.

Possibly related issues are #5 (image cropping module), #367 (Create Contrast Module), #157 (Add a Contrast module), #488 (White balance module), and #434 (Rotate module).

1 similar comment
@gitmate
Copy link

gitmate bot commented Jan 5, 2019

GitMate.io thinks the contributor most likely able to help you is @jywarren.

Possibly related issues are #5 (image cropping module), #367 (Create Contrast Module), #157 (Add a Contrast module), #488 (White balance module), and #434 (Rotate module).

@aashna27
Copy link

aashna27 commented Jan 7, 2019

@jywarren could you please have a look at it and then I would like to work on it.

@jywarren
Copy link
Member

jywarren commented Jan 7, 2019 via email

@aashna27
Copy link

aashna27 commented Jan 7, 2019 via email

@harshkhandeparkar
Copy link
Member

@aashna27 from what I know about this stuff, I think exposure is the amount of light entering the lens of a camera. Increase in exposure means that more light is going to enter the lens and photos in the night are going to look better and visibility will increase but with brightness the photo is only going to look brighter. If this issue is about the same exposure then I think this might not be possible digitally as it s a physical thing. Correct me if I'm wrong. @jywarren @kindanduseful

@harshkhandeparkar
Copy link
Member

harshkhandeparkar commented Jan 27, 2019

Ah I just found some info here it says that exposure depends upon physical factors such as aperture of the lens

@aashna27
Copy link

aashna27 commented Jan 27, 2019 via email

@harshkhandeparkar
Copy link
Member

harshkhandeparkar commented Jan 27, 2019 via email

@vibhorgupta-gh
Copy link

@harshkhandeparkar @aashna27 @jywarren
done at #721

I just added the exposure module. The logic behind the module was pretty straight forward, the only catch was as aforementioned, it depended upon physical factors of ISO value, shutter speed and camera aperture. After researching a bit, I put the EV (exposure value, used to calculate/correct the image exposure) as a range of -5 to 5 with a 0.1 step size. This is a standard step size for the increment for ISO values of 100-200.
Of course, as a software handling image processing we can't handle all values of ISO available in cameras, but we can certainly handle the majority/common ones. Thoughts?

@harshkhandeparkar harshkhandeparkar added the has-pull-request Issues which have a PR open label Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement has-pull-request Issues which have a PR open module New Module idea new-feature
Projects
None yet
Development

No branches or pull requests

5 participants