Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide alternative quick-add menus for different kinds of tools #856

Open
jywarren opened this issue Mar 14, 2019 · 2 comments
Open

Provide alternative quick-add menus for different kinds of tools #856

jywarren opened this issue Mar 14, 2019 · 2 comments

Comments

@jywarren
Copy link
Member

The quick-add menu is really great:

image

But we could imagine other types of quick-add menus, maybe to use different "effects" like this:

image

Could we make it possible to switch to another "quick add" menu instead of this one, that might feature a different set of quick add modules?

We'd probably have to change this function to accept a collection of modules and settings:

https://github.com/publiclab/image-sequencer/blob/main/examples/lib/insertPreview.js

This should be easy; we can just add this as a parameter and default it to the current set:

var previewSequencerSteps = {
"resize": "125%",
"brightness": "20",
"saturation": "5",
"rotate": 90,
"contrast": 90,
"crop": {
"x": 0,
"y": 0,
"w": "(50%)",
"h": "(50%)",
"noUI": true
}
}

so like:

  function updatePreviews(src, selector, steps) {

// ...

    var previewSequencerSteps = steps || {
      "resize": "125%",
      "brightness": "20",
      "saturation": "5",

Then we'd call it like we do here:

insertPreview.updatePreviews(reader.result,'addStep');

but with a different set of steps.

But which steps? Can we set it to a range of brightnesses or tints? Similar to the above example, or use some that are like Instagram filters?

@harshithpabbati
Copy link

harshithpabbati commented Mar 21, 2019

@jywarren can you explain me what to do ??? I mean what changes should I do???

@YogeshSharma01
Copy link

hi @jywarren well i understand your point with these quick-add menus. Here you want to add more like these like different filters on images ? right ? well i would like to work on this allow me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants