Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

1000 contributions PR #1008

Merged
merged 2 commits into from Apr 15, 2019
Merged

1000 contributions PR #1008

merged 2 commits into from Apr 15, 2019

Conversation

harshkhandeparkar
Copy link
Member

Fixes #[Add issue number here.]

Image Sequencer completed 1000 contributions 馃帀. Changed the PR template to celebrate.

Newcomers don't fully understand where to put the issue number and end up putting the number in the square brackets like #[254]. This will no longer happen (hopefully)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@harshkhandeparkar
Copy link
Member Author

harshkhandeparkar commented Apr 12, 2019

@publiclab/is-reviewers

@jywarren jywarren merged commit 3772f78 into main Apr 15, 2019
@harshkhandeparkar harshkhandeparkar deleted the pr-template branch June 7, 2019 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants