Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codecov #1014

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Add codecov #1014

merged 1 commit into from
Apr 15, 2019

Conversation

Divy123
Copy link
Member

@Divy123 Divy123 commented Apr 15, 2019

Fixes #774

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below

@Divy123
Copy link
Member Author

Divy123 commented Apr 15, 2019

@jywarren I have added code coverage here.
Please review.
Thanks!!

@Divy123
Copy link
Member Author

Divy123 commented Apr 15, 2019

Also it works successfully by adding the live status of our code coverage like this to the readme.

Codecov

@jywarren
Copy link
Member

This is great!!! I'll merge now and we should see if we can get coverage to appear in PR comments or checks!!

@jywarren jywarren merged commit 6ba6045 into publiclab:main Apr 15, 2019
@jywarren
Copy link
Member

jywarren commented Apr 15, 2019 via email

@jywarren
Copy link
Member

Hmm, @Divy123 do you see this? #1015 isn't it supposed to leave a comment?

@jywarren
Copy link
Member

@jywarren
Copy link
Member

#1016

@Divy123
Copy link
Member Author

Divy123 commented Apr 16, 2019

Thanks @jywarren so much for this!!
We will now have report at every PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add code coverage
2 participants