text-overlay in Node

[aashna27]

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• ask @publiclab/is-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[aashna27]

@harshkhandeparkar any idea on this?

[aashna27]

@tech4GT @Divy123

[tech4GT]

Looks like colorbar was affected somehow, that's the test which is failing. Try running it maybe you'll find the problem.

[codecov]

Codecov Report

Merging #1125 into main will increase coverage by 0.11%.
The diff coverage is 37.5%.

@@            Coverage Diff             @@
##             main    #1125      +/-   ##
==========================================
+ Coverage   55.66%   55.78%   +0.11%     
==========================================
  Files         114      114              
  Lines        2357     2352       -5     
  Branches      364      363       -1     
==========================================
  Hits         1312     1312              
+ Misses       1045     1040       -5

Impacted Files	Coverage Δ
src/modules/TextOverlay/Module.js	33.33% <37.5%> (+9.8%)	⬆️

[aashna27]

@jywarren @publiclab/reviewers I have changed this and text-overlay now works for node. Please review. The reason this one wasn't working on node was that $ wasn't being recognized.

[Divy123]

Great finding @aashna27 and is there something to change in the docs?

Rest I think this is ready to be merged 🎉 🎉

[aashna27]

Great finding @aashna27 and is there something to change in the docs?

Rest I think this is ready to be merged tada tada

Thanks! we dont have docs I ll add them! 🙈

[Divy123]

Thanks! we dont have docs I ll add them!

Yeah, thanks a lot!!

[jywarren]

Hooray!!! Great work!!!

[harshkhandeparkar]

lol, I was reviewing this.

[jywarren]

Sorry, I saw only docs required and 2 reviews (myself included!) so I went ahead! Sorry Harsh, let's try to coordinate better in the future, I'll keep a closer eye out. The pending reviewers are not easy to see from mobile view!

[harshkhandeparkar]

It actually doesn't matter much. I was the one who delayed this.

[aashna27]

Thanks a lot everyone for the quick merge! 🤗