Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix for insert-step btn not working #1131

Merged
merged 2 commits into from Jun 26, 2019

Conversation

Divy123
Copy link
Member

@Divy123 Divy123 commented Jun 25, 2019

Fixes #0000 (<=== Replace 0000 with the Issue Number)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #1131 into main will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1131   +/-   ##
=======================================
  Coverage   55.58%   55.58%           
=======================================
  Files         113      113           
  Lines        2346     2346           
  Branches      364      364           
=======================================
  Hits         1304     1304           
  Misses       1042     1042
Impacted Files Coverage Δ
examples/lib/intermediateHtmlStepUi.js 10.34% <0%> (ø) ⬆️

@Divy123
Copy link
Member Author

Divy123 commented Jun 25, 2019

@jywarren its done

@jywarren jywarren merged commit 2c58edf into publiclab:main Jun 26, 2019
@jywarren
Copy link
Member

Great!!

@harshkhandeparkar
Copy link
Member

@Divy123 sorry you had to take this trouble. I will try to fix the issue.

@Divy123
Copy link
Member Author

Divy123 commented Jun 26, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants