Fix ScopeQuery

[harshkhandeparkar]

Fixes #0000 (<=== Replace 0000 with the Issue Number)

@Divy123 @jywarren

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• ask @publiclab/is-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[harshkhandeparkar]

@jywarren try to merge this ASAP. @Divy123 please review this. I recommend you to review this locally. Thanks a lot!

[Divy123]

@harshkhandeparkar request you to send the following:

1. GIF of working demo, showing insert step button working.
2. Screenshot of browser console.

[harshkhandeparkar]

@Divy123 it seems to work offline but I think it would be better if you check it on your PC itself instead of me sending a pic, to make sure everything really works.

[Divy123]

Sure!

[harshkhandeparkar]

And the browser has no errors. Not even the .contains error.

[Divy123]

Checking it now.

[codecov]

Codecov Report

Merging #1132 into main will decrease coverage by 0.19%.
The diff coverage is 11.11%.

@@            Coverage Diff            @@
##             main    #1132     +/-   ##
=========================================
- Coverage   55.58%   55.39%   -0.2%     
=========================================
  Files         113      113             
  Lines        2346     2356     +10     
  Branches      364      364             
=========================================
+ Hits         1304     1305      +1     
- Misses       1042     1051      +9

Impacted Files	Coverage Δ
examples/lib/scopeQuery.js	18.51% <0%> (-5.3%)	⬇️
examples/lib/defaultHtmlStepUi.js	12.19% <33.33%> (+0.39%)	⬆️
examples/lib/intermediateHtmlStepUi.js	10.16% <8.33%> (-0.18%)	⬇️

[Divy123]

@harshkhandeparkar facing some issues with npm right now.
@publiclab/is-reviewers please someone test this out locally and post here some screenshots.

[harshkhandeparkar]

What is the npm issue? Maybe I can help

…

On Wed, 26 Jun, 2019, 9:00 PM Slytherin, ***@***.***> wrote: @harshkhandeparkar <https://github.com/HarshKhandeparkar> facing some issues with npm right now. @publiclab/is-reviewers <https://github.com/orgs/publiclab/teams/is-reviewers> please someone test this out locally and post here some screenshots. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1132?email_source=notifications&email_token=AIJI5HZXJ2GOULFZOFO7NVDP4ODQ7A5CNFSM4H3S3LO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYT5HYI#issuecomment-505926625>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIJI5H7FY7EQVQZDTRTB55TP4ODQ7ANCNFSM4H3S3LOQ> .

[Divy123]

Working too slow, looking into now!!

[harshkhandeparkar]

What is working too slow? Download?

…

On Wed, 26 Jun, 2019, 9:02 PM Slytherin, ***@***.***> wrote: Working too slow, looking into now!! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1132?email_source=notifications&email_token=AIJI5H7FJ5OUOAR5RJLHLK3P4ODX3A5CNFSM4H3S3LO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYT5N4Q#issuecomment-505927410>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIJI5H7FFHBRYRKFBKI5D2TP4ODX3ANCNFSM4H3S3LOQ> .

[Divy123]

npm install and especially electron takes a lot of time

[harshkhandeparkar]

Hmm. I think it is the download. It downloads chromium. We should really switch to yarn

…

On Wed, 26 Jun, 2019, 9:07 PM Slytherin, ***@***.***> wrote: npm install and especially electron takes a lot of time — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1132?email_source=notifications&email_token=AIJI5H4WTGHFURRJMIAZGDTP4OEKXA5CNFSM4H3S3LO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYT55QY#issuecomment-505929411>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIJI5H54VNAODSQLYPB7ZBLP4OEKXANCNFSM4H3S3LOQ> .

[Divy123]

PR ready to be merged!!
Great work @harshkhandeparkar .
Thanks a lot.

[Divy123]

I think this is great.
@jywarren request you to merge this as soon as possible. Maybe what Harsh has done here and work in my PR can get everything fixed together.

[harshkhandeparkar]

@Divy123 thanks!
Which PR are you working on btw?

[Divy123]

Actually this PR corrects the insert-step button but the internal working is also broken, so I am working on that.

[harshkhandeparkar]

Yes I noticed that. I first thought that it was my mistake but it wasn't.

[Divy123]

No its not your PR something else broke it. I have fixed the working but still some more things to be fixed. Working on it.

[harshkhandeparkar]

Thanks a lot!!!

…

On Mon, 1 Jul, 2019, 9:02 PM Jeffrey Warren, ***@***.***> wrote: Merged #1132 <#1132> into main. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1132?email_source=notifications&email_token=AIJI5H3QHBDFVA6QTZY5F3DP5IPP3A5CNFSM4H3S3LO2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSIQOV4A#event-2451630832>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIJI5HYIAOCCIQQONEGHKIDP5IPP3ANCNFSM4H3S3LOQ> .

[jywarren]

Great, merged this. where is your PR now, and what's our status re: #1100 and to the urgent issue from and #833 (comment) ?

[jywarren]

Thank you! Just coming online after a weekend! Trying to get synced up but also working on high priority publication of MapKnitter!