Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alphabetically arranged the MODULES.md file #1167 - Sorted index and the corpus #1186

Merged
merged 3 commits into from Aug 3, 2019

Conversation

kirito-k
Copy link

@kirito-k kirito-k commented Jul 27, 2019

Fixes #1167

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@codecov
Copy link

codecov bot commented Jul 27, 2019

Codecov Report

Merging #1186 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1186   +/-   ##
=======================================
  Coverage   55.31%   55.31%           
=======================================
  Files         116      116           
  Lines        2381     2381           
  Branches      364      364           
=======================================
  Hits         1317     1317           
  Misses       1064     1064

docs/MODULES.md Outdated
34. [Saturation](#saturation-module)
35. [Segmented-Colormap](#segmented-colormap-module)
36. [Threshold](#threshold)
37. [Tint](#tint)
38. [Text-Overlay](#text-overlay)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey your work is really great just a little change can you change the order for text overlay after segmented? Sorry for the trouble

@kirito-k
Copy link
Author

Hey I did make changes and pushed them. Did you receive anything?

@aashna27
Copy link

Hey yeah cool, the changes exist!! Hooray great work

@aashna27
Copy link

@publiclab/reviewers let's have a look and approve this to get it merged at the earliest!

Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks @kirito-k

@aashna27
Copy link

I guess only @jywarren can merge this so once he comes next friday this pr can be prioritised to be merged first.

@kirito-k
Copy link
Author

@aashna27 Thank you so much. :)

@aashna27
Copy link

aashna27 commented Aug 2, 2019

@jywarren this can be merged.

@jywarren jywarren merged commit 74ef42f into publiclab:main Aug 3, 2019
@welcome
Copy link

welcome bot commented Aug 3, 2019

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will be published to https://beta.sequencer.publiclab.org in a day or two.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

@jywarren
Copy link
Member

jywarren commented Aug 3, 2019

Great work! Thanks so much!!!

jywarren pushed a commit that referenced this pull request Dec 16, 2019
…the corpus (#1186)

* Sorted index and the corpus

* Changed text overlay sequence
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alphabetically arrange modules in Module docs
5 participants