Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes:grid-overlay for negetive input and 0 #1205

Merged
merged 4 commits into from Aug 19, 2019

Conversation

aashna27
Copy link

Fixes #1203

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below

0 value is now mapped to 1 as the || operator makes it to 100 and also using 0 will lead to an infinite loop. Also now negetive values will also not lead to infinite loop.

@aashna27 aashna27 changed the title grid-overlay for negetive input and 0 Fixes:grid-overlay for negetive input and 0 Aug 10, 2019
@codecov
Copy link

codecov bot commented Aug 10, 2019

Codecov Report

Merging #1205 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1205   +/-   ##
=======================================
  Coverage   55.11%   55.11%           
=======================================
  Files         117      117           
  Lines        2344     2344           
  Branches      360      360           
=======================================
  Hits         1292     1292           
  Misses       1052     1052

@jywarren
Copy link
Member

This looks good - is it ready to merge? Thank you!

@jywarren jywarren merged commit c7980c1 into publiclab:main Aug 19, 2019
@jywarren
Copy link
Member

Merged! Thank you!

jywarren pushed a commit that referenced this pull request Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grid -overlay error only works for certain values and locks up
2 participants