Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODE_OF_CONDUCT.md #1248

Merged
merged 2 commits into from Dec 9, 2019
Merged

Update CODE_OF_CONDUCT.md #1248

merged 2 commits into from Dec 9, 2019

Conversation

sashadev-sky
Copy link
Member

@sashadev-sky sashadev-sky commented Sep 5, 2019

update to reflect the updates on
https://publiclab.org/conduct Aug 28 2019, and also standardize format to match LDI, Mk, etc.

Fixes #1249 (<=== Replace 0000 with the Issue Number)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

update to reflect the updates on 
https://publiclab.org/conduct Aug 28 2019, and also standardize format to match LDI, Mk, etc.
@sashadev-sky
Copy link
Member Author

@publiclab/is-reviewers

@codecov
Copy link

codecov bot commented Sep 5, 2019

Codecov Report

Merging #1248 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1248   +/-   ##
=======================================
  Coverage   32.13%   32.13%           
=======================================
  Files         108      108           
  Lines        1982     1982           
  Branches      292      292           
=======================================
  Hits          637      637           
  Misses       1345     1345

Copy link
Member

@grvsachdeva grvsachdeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!!

@grvsachdeva grvsachdeva requested a review from a team September 5, 2019 21:24
@sashadev-sky
Copy link
Member Author

Thanks for updating!!
@gauravano
Lol thank you for merging all of these!! I want to get at least the main ones..

We could also create one default code_of_conduct file for the organization: https://help.github.com/en/articles/creating-a-default-community-health-file-for-your-organization

but that would require creating a repository for storing default files, and then deleting it from every repo. What are your thoughts?

@grvsachdeva
Copy link
Member

Hey, thanks for sharing this link. This seems cool, and I think, we should do this, as we have many projects now and using this we would be consistent as well as updated without hassle in all of them.
@jywarren what do you think?

Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sashadev-sky
Copy link
Member Author

sashadev-sky commented Dec 7, 2019

@gauravano would it be ok to deploy this one for now?

@grvsachdeva
Copy link
Member

Sure @sashadev-sky, we can merge this one. @harshkhandeparkar @jywarren please merge this.

@jywarren jywarren merged commit 5c76cb4 into main Dec 9, 2019
@jywarren
Copy link
Member

jywarren commented Dec 9, 2019

Great, thank you!!!

jywarren pushed a commit that referenced this pull request Dec 16, 2019
update to reflect the updates on 
https://publiclab.org/conduct Aug 28 2019, and also standardize format to match LDI, Mk, etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update code of conduct
4 participants