fixes bugs in gamma-correction module #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1256 +/- ##
==========================================
+ Coverage 32.05% 32.07% +0.01%
==========================================
Files 107 107
Lines 1987 1986 -1
Branches 296 296
==========================================
Hits 637 637
+ Misses 1350 1349 -1
|
|
@harshkhandeparkar @jywarren @aashna27 can you please review this PR!!! |
|
@jywarren @harshkhandeparkar can you please review this PR!!! |
|
I am so sorry that I can't review this yet. I have a test coming up. Will you please hold on till Monday? I will surely review it that day. Apologies. |
|
@jywarren @harshkhandeparkar can you please review this PR!! |
harshkhandeparkar
approved these changes
Oct 3, 2019
|
@jywarren can you please review this PR!!! |
jywarren
approved these changes
Oct 7, 2019
|
This is great. Thank you for the fix!!! |
jywarren
pushed a commit
that referenced
this pull request
Dec 16, 2019
* fixes gamma-correction module slider * Update info.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1255
fixing of the slider
val was being divided by defaults.adjustment which was 0.2.this might have been done by mistake in PR #763
before changes for gamma value equal to 0.5
after changes for gamma value equal to 0.5
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test@publiclab/is-reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!