fixes insert step functionality

[keshav234156]

Fixes #1261

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• ask @publiclab/is-reviewers for help, in a comment below
• Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

[codecov]

Codecov Report

Merging #1266 into main will increase coverage by 0.19%.
The diff coverage is 12.5%.

@@            Coverage Diff             @@
##             main    #1266      +/-   ##
==========================================
+ Coverage   32.07%   32.26%   +0.19%     
==========================================
  Files         107      107              
  Lines        1986     1971      -15     
  Branches      296      292       -4     
==========================================
- Hits          637      636       -1     
+ Misses       1349     1335      -14

Impacted Files	Coverage Δ
examples/lib/intermediateHtmlStepUi.js	11.36% <12.5%> (+1.19%)	⬆️

[keshav234156]

@jywarren @harshkhandeparkar can you please review this PR!!!

[harshkhandeparkar]

Do you know why this is happening?

[keshav234156]

@harshkhandeparkar could you please tell the step to reproduce the above

[harshkhandeparkar]

Add a few steps, insert any step and try collapsing the dropdowns.

[keshav234156]

there might be some error here that is causing this behavior

image-sequencer/examples/lib/defaultHtmlStepUi.js

Line 192 in 44f5cb4

$step('.toggle').on('click', () => {

This behaviour is shown in beta version as well.So don't think that it has been caused by this PR.There are lots of other error in examples/lib/defaultHtmlStepUi.js,Will open a issue for same

[harshkhandeparkar]

ok. ty.

[keshav234156]

@jywarren can you please review this PR!!!

[jywarren]

This is looking good -- do you think we could make the name here more specific? Like, insert what? Insert step, right?

Thank you!!!

[keshav234156]

@jywarren was thinking the same but insertstep was already defined in line 77,so left as it is

[jywarren]

Thanks for the review @vaibhavmatta have you tested this locally and confirmed the fix? Thanks all!

[vaibhavmatta]

@jywarren Yes!! Though I tested it for the first time, but it worked fine for me. THANKS

[jywarren]

Great, thanks all!!!!!