Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code of conduct badge in README.md #1326

Merged
merged 2 commits into from
Jan 1, 2020
Merged

Added code of conduct badge in README.md #1326

merged 2 commits into from
Jan 1, 2020

Conversation

vgadodia
Copy link

@vgadodia vgadodia commented Dec 5, 2019

Fixes #1306

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@welcome
Copy link

welcome bot commented Dec 5, 2019

Thanks for opening this pull request!
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@codecov
Copy link

codecov bot commented Dec 5, 2019

Codecov Report

Merging #1326 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1326   +/-   ##
=======================================
  Coverage   66.12%   66.12%           
=======================================
  Files         125      125           
  Lines        2571     2571           
  Branches      404      404           
=======================================
  Hits         1700     1700           
  Misses        871      871

@debck
Copy link
Member

debck commented Dec 5, 2019

@vgadodia Do mention the issue number in the description as Fixes #<issue number>
Rest all looks good. Great work 🎉

@debck
Copy link
Member

debck commented Dec 5, 2019

@ananyaarun need your review

@vgadodia vgadodia changed the title Update README.md Update README.md Fixes #1326 Dec 5, 2019
@vgadodia vgadodia changed the title Update README.md Fixes #1326 Update README.md Fixes Dec 5, 2019
@ananyaarun ananyaarun changed the title Update README.md Fixes Added code of conduct badge in README.md Dec 5, 2019
@ananyaarun
Copy link
Member

Hi @vgadodia Great 🎉
I have changes the name of ur PR and added the issue number in the PR template.
Make sure you do these next time :)
Thanks !!

@vgadodia
Copy link
Author

vgadodia commented Dec 5, 2019

Thank you very much for your advice. I will definitely try to do those things next time :)

@jywarren jywarren merged commit d83703c into publiclab:main Jan 1, 2020
@welcome
Copy link

welcome bot commented Jan 1, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will be published to https://beta.sequencer.publiclab.org in a day or two.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

@jywarren
Copy link
Member

jywarren commented Jan 1, 2020

Thank you so much!!! Apologies for the slow response during the holdiays!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Code of Conduct badge in readme
5 participants