Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCI] Standardised UI util code comments #1344

Merged
merged 7 commits into from Jan 1, 2020
Merged

[GCI] Standardised UI util code comments #1344

merged 7 commits into from Jan 1, 2020

Conversation

harshkhandeparkar
Copy link
Member

@harshkhandeparkar harshkhandeparkar commented Dec 9, 2019

Fixes #1339 (<=== Replace 0000 with the Issue Number)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@codecov
Copy link

codecov bot commented Dec 9, 2019

Codecov Report

Merging #1344 into main will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1344   +/-   ##
=======================================
  Coverage   66.12%   66.12%           
=======================================
  Files         125      125           
  Lines        2571     2571           
  Branches      404      404           
=======================================
  Hits         1700     1700           
  Misses        871      871
Impacted Files Coverage Δ
examples/lib/scopeQuery.js 18.51% <ø> (ø) ⬆️
examples/lib/insertPreview.js 13.51% <0%> (ø) ⬆️
examples/lib/mapHtmltypes.js 8% <100%> (ø) ⬆️

@harshkhandeparkar harshkhandeparkar requested review from SidharthBansal, jywarren and a team and removed request for jywarren December 10, 2019 16:56
@SidharthBansal
Copy link
Member

@jywarren ready to merge. Kindly merge this

@jywarren jywarren merged commit 1db650c into publiclab:main Jan 1, 2020
@jywarren
Copy link
Member

jywarren commented Jan 1, 2020

Thank you so much!!! Apologies for the slow response during the holdiays!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardise UI util code comments
3 participants