[GCI] Standardised Blur module code comments #1347

harshkhandeparkar · 2019-12-09T14:53:51Z

Fixes #1342 (<=== Replace 0000 with the Issue Number)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
code is in uniquely-named feature branch and has no merge conflicts
PR is descriptively titled
ask @publiclab/is-reviewers for help, in a comment below
Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

codecov · 2019-12-09T14:59:59Z

Codecov Report

Merging #1347 into main will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##             main    #1347   +/-   ##
=======================================
  Coverage   66.12%   66.12%           
=======================================
  Files         125      125           
  Lines        2571     2571           
  Branches      404      404           
=======================================
  Hits         1700     1700           
  Misses        871      871

Impacted Files	Coverage Δ
src/modules/Blur/Blur.js	`100% <100%> (ø)`	⬆️

harshkhandeparkar · 2019-12-09T15:03:09Z

@SidharthBansal please try to get these PRs merged quickly. I don't think I will be free next month so I want to complete as many tasks as possible this month itself. Thanks!

Divy123 · 2019-12-09T15:08:05Z

@harshkhandeparkar I will be reviewing PRs from next week. But please be patient, as we have to make it feasible for all the mentors and participants to participate smoothly, we will try our level best. Next thing is I think Siddharth will be doing it whenever he will be here,and we have to make it open for all. So we cannot make it a personalized experience for someone.

harshkhandeparkar · 2019-12-09T15:12:29Z

@Divy123 yeah sure. I am in a hurry because the task I have already accepted is about to hit the deadline and also I hadn't expected it to take such a long time. Sorry if I am causing inconvenience to others. If I had known that I would have to split this task or if the task had been split earlier, I would have left it to claim at the end or let someone else claim it. Sorry still.

harshkhandeparkar · 2019-12-09T15:14:07Z

My school schedule is going to be busy now on. This is the only month when I got a bit of free time. Otherwise, I wouldn't even have participated.

SidharthBansal · 2019-12-09T16:28:02Z

I can review your prs tomorrow. I am busy today. He is assigned one hall-of-fame task. I asked him to divide it into multiple PRs so that we can review it easy.
Thanks all of you

SidharthBansal · 2019-12-09T16:28:23Z

Codeclimate is failing please check

SidharthBansal

🎉

harshkhandeparkar · 2019-12-09T17:33:10Z

Is there a reason why you closed the PR?

SidharthBansal · 2019-12-09T18:01:21Z

By mistake

…

On Mon, Dec 9, 2019 at 11:03 PM Harsh Khandeparkar ***@***.***> wrote: Is there a reason why you closed the PR? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#1347?email_source=notifications&email_token=AFAAEQZLK2C55SLKG47R2RTQXZ6NPA5CNFSM4JYKPFVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGJ74CY#issuecomment-563346955>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFAAEQ2VCNTHPEBUBX4C2ZLQXZ6NPANCNFSM4JYKPFVA> .

SidharthBansal · 2019-12-09T18:01:39Z

Please open it On Mon, Dec 9, 2019 at 11:31 PM Sidharth Bansal < bansal.sidharthcode@gmail.com> wrote:

…

By mistake On Mon, Dec 9, 2019 at 11:03 PM Harsh Khandeparkar < ***@***.***> wrote: > Is there a reason why you closed the PR? > > — > You are receiving this because you modified the open/close state. > Reply to this email directly, view it on GitHub > <#1347?email_source=notifications&email_token=AFAAEQZLK2C55SLKG47R2RTQXZ6NPA5CNFSM4JYKPFVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGJ74CY#issuecomment-563346955>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AFAAEQ2VCNTHPEBUBX4C2ZLQXZ6NPANCNFSM4JYKPFVA> > . >

harshkhandeparkar · 2019-12-09T18:02:05Z

Ohk. On Mon, 9 Dec, 2019, 11:31 PM Sidharth Bansal, <notifications@github.com> wrote:

…

By mistake On Mon, Dec 9, 2019 at 11:03 PM Harsh Khandeparkar < ***@***.***> wrote: > Is there a reason why you closed the PR? > > — > You are receiving this because you modified the open/close state. > Reply to this email directly, view it on GitHub > < #1347?email_source=notifications&email_token=AFAAEQZLK2C55SLKG47R2RTQXZ6NPA5CNFSM4JYKPFVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGJ74CY#issuecomment-563346955 >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AFAAEQ2VCNTHPEBUBX4C2ZLQXZ6NPANCNFSM4JYKPFVA > > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1347?email_source=notifications&email_token=AIJI5HYPSKNV2Y2PVCA3C7LQX2BXHA5CNFSM4JYKPFVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGKCRFQ#issuecomment-563357846>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIJI5H7SBHLXKZ2HUGFMVX3QX2BXHANCNFSM4JYKPFVA> .

harshkhandeparkar · 2019-12-21T15:23:57Z

@jywarren can this and the other comments GCI PRs be merged now?

jywarren · 2019-12-21T16:59:58Z

Yes! Let's rebase and we should be good to go! Thanks!!

harshkhandeparkar · 2019-12-21T17:02:19Z

Thank you!

…

On Sat, 21 Dec, 2019, 10:30 PM Jeffrey Warren, ***@***.***> wrote: Yes! Let's rebase and we should be good to go! Thanks!! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1347?email_source=notifications&email_token=AIJI5H5VSHV43HTUB77LUQLQZZDRBA5CNFSM4JYKPFVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHO7V5Y#issuecomment-568195831>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIJI5HYT7E6VDPDXNG53RSLQZZDRBANCNFSM4JYKPFVA> .

jywarren · 2020-01-01T16:54:01Z

Hmm, do you know what these errors are? Thanks!

harshkhandeparkar · 2020-01-01T16:56:31Z

I'm not sure. Gifshot does use canvas but these tests don't run on GIFs so there is no question of Gifshot. But these errors are definitely related to canvas. Perhaps one of the modules which requires canvas doesn't check for the `inBrowser` flag...

…

On Wed, 1 Jan, 2020, 10:24 PM Jeffrey Warren, ***@***.***> wrote: Hmm, do you know what these errors are? Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1347?email_source=notifications&email_token=AIJI5H3DXWIDRX5CVLW6TW3Q3TDCVA5CNFSM4JYKPFVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH5IR4Y#issuecomment-570067187>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIJI5H2VGM6TJ53UK73PT2LQ3TDCVANCNFSM4JYKPFVA> .

keshav234156 · 2020-01-01T17:43:54Z

@jywarren it seem like it was some travis fault.Now it's fine.

jywarren · 2020-01-01T17:52:12Z

Looking to merge this one next after updating branch!

jywarren

Awesome!!!!

standardise comments

d9b06b7

harshkhandeparkar requested review from a team and SidharthBansal December 9, 2019 14:53

SidharthBansal approved these changes Dec 9, 2019

View reviewed changes

SidharthBansal closed this Dec 9, 2019

SidharthBansal reopened this Dec 9, 2019

jywarren and others added 3 commits December 9, 2019 17:00

Merge branch 'main' into blur-comments

404d1e8

Merge branch 'main' into blur-comments

d6e4fc4

Merge branch 'main' into blur-comments

844e2c5

harshkhandeparkar added the ready-to-merge label Dec 14, 2019

harshkhandeparkar added 3 commits December 16, 2019 16:57

Merge branch 'main' into blur-comments

dd501a2

Merge branch 'main' into blur-comments

a03e8be

Merge branch 'main' into blur-comments

26a6917

Merge branch 'main' into blur-comments

1f3cf5d

Merge branch 'main' into blur-comments

973c838

Merge branch 'main' into blur-comments

b1549c6

jywarren approved these changes Jan 1, 2020

View reviewed changes

jywarren merged commit 0bf1780 into publiclab:main Jan 1, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GCI] Standardised Blur module code comments #1347

[GCI] Standardised Blur module code comments #1347

harshkhandeparkar commented Dec 9, 2019 •

edited

Loading

codecov bot commented Dec 9, 2019 •

edited

Loading

harshkhandeparkar commented Dec 9, 2019

Divy123 commented Dec 9, 2019

harshkhandeparkar commented Dec 9, 2019 •

edited

Loading

harshkhandeparkar commented Dec 9, 2019

SidharthBansal commented Dec 9, 2019

SidharthBansal commented Dec 9, 2019

SidharthBansal left a comment

harshkhandeparkar commented Dec 9, 2019

SidharthBansal commented Dec 9, 2019 via email

SidharthBansal commented Dec 9, 2019 via email

harshkhandeparkar commented Dec 9, 2019 via email

harshkhandeparkar commented Dec 21, 2019

jywarren commented Dec 21, 2019

harshkhandeparkar commented Dec 21, 2019 via email

jywarren commented Jan 1, 2020

harshkhandeparkar commented Jan 1, 2020 via email

keshav234156 commented Jan 1, 2020

jywarren commented Jan 1, 2020

jywarren left a comment

[GCI] Standardised Blur module code comments #1347

[GCI] Standardised Blur module code comments #1347

Conversation

harshkhandeparkar commented Dec 9, 2019 • edited Loading

codecov bot commented Dec 9, 2019 • edited Loading

Codecov Report

harshkhandeparkar commented Dec 9, 2019

Divy123 commented Dec 9, 2019

harshkhandeparkar commented Dec 9, 2019 • edited Loading

harshkhandeparkar commented Dec 9, 2019

SidharthBansal commented Dec 9, 2019

SidharthBansal commented Dec 9, 2019

SidharthBansal left a comment

Choose a reason for hiding this comment

harshkhandeparkar commented Dec 9, 2019

SidharthBansal commented Dec 9, 2019 via email

SidharthBansal commented Dec 9, 2019 via email

harshkhandeparkar commented Dec 9, 2019 via email

harshkhandeparkar commented Dec 21, 2019

jywarren commented Dec 21, 2019

harshkhandeparkar commented Dec 21, 2019 via email

jywarren commented Jan 1, 2020

harshkhandeparkar commented Jan 1, 2020 via email

keshav234156 commented Jan 1, 2020

jywarren commented Jan 1, 2020

jywarren left a comment

Choose a reason for hiding this comment

harshkhandeparkar commented Dec 9, 2019 •

edited

Loading

codecov bot commented Dec 9, 2019 •

edited

Loading

harshkhandeparkar commented Dec 9, 2019 •

edited

Loading