Dropdown 'Select a Module' fix #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@publiclab/reviewers, please check |
Codecov Report
@@ Coverage Diff @@
## main #1352 +/- ##
=======================================
Coverage 66.57% 66.57%
=======================================
Files 125 125
Lines 2546 2546
Branches 397 397
=======================================
Hits 1695 1695
Misses 851 851 |
|
Do you think adding a few comments to the code would help? |
|
I am not a mentor sorry😅. I am just a student and reviewing others' PRs.
…On Wed, 11 Dec, 2019, 10:11 PM Sparks, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In examples/demo.js
<#1352 (comment)>
:
> @@ -8,7 +8,27 @@ var defaultHtmlSequencerUi = require('./lib/defaultHtmlSequencerUi.js'),
window.onload = function () {
sequencer = ImageSequencer();
- function refreshOptions() {
+ options = {
+ sortField: 'text',
+ openOnFocus: false,
+ onInitialize: function () {
+ var that = this;
So can you accept gci task now?
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#1352?email_source=notifications&email_token=AIJI5HYYKN76XLJXDKLUSLDQYEJ5NA5CNFSM4JZI6PO2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCO25CRY#discussion_r356709349>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIJI5HZ2UCJFBWYGQEIMCPTQYEJ5NANCNFSM4JZI6POQ>
.
|
|
@keshav234156 , can you accept my GCI task? |
harshkhandeparkar
requested changes
Dec 12, 2019
examples/demo.js
Outdated
| this.$control.on("click", () => { | ||
| this.ignoreFocusOpen = true; | ||
| setTimeout(() => { | ||
| this.ignoreFocusOpen = false; // trigger onFocus and open dropdown |
There was a problem hiding this comment.
Sorry but I forgot to tell you that comments need to follow certain rules from now on. We want to increase the consistency of docs in the codebase. Please start with a Capital letter and end with a full stop.
There was a problem hiding this comment.
Please add full stops. Sorry for delaying this.
There was a problem hiding this comment.
Like this? Sorry I’m not sure that understood word “full stop” correctly
keshav234156
approved these changes
Dec 12, 2019
harshkhandeparkar
approved these changes
Dec 12, 2019
keshav234156
approved these changes
Dec 12, 2019
jywarren
approved these changes
Dec 12, 2019
|
Awesome work! Thank you! |
jywarren
pushed a commit
that referenced
this pull request
Dec 16, 2019
* Update demo.js * Codeclimate * Update demo.js * Code comments * Comments codestyle * Update demo.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1307
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test@publiclab/is-reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!