Jest testing & test for add step

[keshav234156]

Fixes #1242

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• ask @publiclab/is-reviewers for help, in a comment below
• Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

[keshav234156]

cc: @jywarren @harshkhandeparkar

[keshav234156]

run it with npm run test-ui-2

[codecov]

Codecov Report

Merging #1366 into main will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1366   +/-   ##
=======================================
  Coverage   66.23%   66.23%           
=======================================
  Files         125      125           
  Lines        2559     2559           
  Branches      400      400           
=======================================
  Hits         1695     1695           
  Misses        864      864

[jywarren]

This is awesome. Following eagerly! Please ping me once the path is local. Great work! cc @harshkhandeparkar @vaibhavmatta @tech4GT and others! ♥️😁🎉

[jywarren]

Could you add the run command to the overall test trigger so they run in Travis?

[keshav234156]

@jywarren Do you know how can we make relative to examples/index.html ?

[keshav234156]

ohk done with fs library as suggested by @harshkhandeparkar

[keshav234156]

cc: @jywarren

https://travis-ci.org/publiclab/image-sequencer/jobs/626434689#L1683

Horray!!!
We have now test running on Travis as well

[keshav234156]

@jywarren Now we just need to add it to npm test-ui command properly . How can we do that?

[jywarren]

This is Awesome!!! Can you try breaking a test to be sure it triggers a Travis failure? 🎉🎉🎉

[keshav234156]

let's check with title

[jywarren]

Great! Ok now we add it here;

image-sequencer/.travis.yml

Line 15 in 4a86abb

- npm run test-ui

[keshav234156]

@jywarren travis failed as i changed title of page

https://travis-ci.org/publiclab/image-sequencer/jobs/626440796#L1709

[jywarren]

Once we've merged, we can write an issue with a longer list of critical UI functions we want to test, and start getting gci folks to pitch in maybe!

[jywarren]

Let's just remove a few of the console.log statements too and add a brief readme entry? Thanks, this is amazing!!!!!

[keshav234156]

@jywarren LGTM

[jywarren]

Ah, I see a merge conflict, can you rebase? Then good to go!!!!! Thanks!

[keshav234156]

@jywarren in which file?

[jywarren]

Oh sorry! Take a look - GitHub has marked the pr as having a conflict. It should show which! But, you can rebase the whole branch to resolve it.

…

On Tue, Dec 17, 2019, 6:47 PM keshav234156 ***@***.***> wrote: in which file? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1366?email_source=notifications&email_token=AAAF6J5KJUQ6MQZIKIJKEVLQZFQIBA5CNFSM4J4BVROKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHELASI#issuecomment-566800457>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAF6J4VCHIBD2OPVKE5II3QZFQIBANCNFSM4J4BVROA> .

[keshav234156]

@jywarren where it is shown in Github whether Pr is having conflicts

Though i have updated the branch.

Are merge conflicts still present

sorry for asking stupid questions here.I have very lot of problems with git

[jywarren]

Ah! I dunno what happened, I saw a message earlier but now it's just asking for 2 reviews. I can bypass but let's aim for 2 in future PRs! Thanks!

[jywarren]

🎉🎉🎉🎉 awesome. Would you have interest in the list of tests issue and/or the readme update? This is so great!!!!!

[keshav234156]

Ok will make list of ui test nedded.some of them are already listed in #1000