-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update demo.css - GCI task for issue #1314 #1368
Conversation
Thanks for opening this pull request! |
Codecov Report
@@ Coverage Diff @@
## main #1368 +/- ##
=======================================
Coverage 66.23% 66.23%
=======================================
Files 125 125
Lines 2559 2559
Branches 400 400
=======================================
Hits 1695 1695
Misses 864 864 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Congrats on merging your first pull request! 🙌🎉⚡️ |
Awesome, thanks!!!! |
My Twitter handle is @itsdnhuan |
@jywarren @harshkhandeparkar @dnhuan I just noticed this. It occurs due to this PR.@dnhuan Please do the required changes. @jywarren @harshkhandeparkar How can we prevent this type of bugs in the future? |
Do you mean the positon of the “Add step” buttong being pushed down to another line? I will take a look at that in a minute. |
@dnhuan It should look like |
@dnhuan this occurs in insert step not dropdown for add step. |
Thank you, I am able to reproduce the problem. Turns out I shouldn't edit a global CSS. Currently trying to find a workaround. |
@dnhuan are you working on it? |
Currently not, but will get back to it tonight. Sorry for the delay, I was busy finishing my finals. |
Fixes #1314
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!