Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update demo.css - GCI task for issue #1314 #1368

Merged
merged 1 commit into from
Dec 18, 2019
Merged

Conversation

dnhuan
Copy link

@dnhuan dnhuan commented Dec 18, 2019

Fixes #1314

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@welcome
Copy link

welcome bot commented Dec 18, 2019

Thanks for opening this pull request!
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@dnhuan dnhuan changed the title Update demo.css Update demo.css - GCI Dec 18, 2019
@dnhuan dnhuan changed the title Update demo.css - GCI Update demo.css - GCI task for issue #1314 Dec 18, 2019
@codecov
Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #1368 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1368   +/-   ##
=======================================
  Coverage   66.23%   66.23%           
=======================================
  Files         125      125           
  Lines        2559     2559           
  Branches      400      400           
=======================================
  Hits         1695     1695           
  Misses        864      864

Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jywarren jywarren merged commit 2e94f20 into publiclab:main Dec 18, 2019
@welcome
Copy link

welcome bot commented Dec 18, 2019

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will be published to https://beta.sequencer.publiclab.org in a day or two.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

@jywarren
Copy link
Member

Awesome, thanks!!!!

@dnhuan
Copy link
Author

dnhuan commented Dec 18, 2019

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will be published to https://beta.sequencer.publiclab.org in a day or two.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

My Twitter handle is @itsdnhuan
Thank you so much!

@keshav234156
Copy link
Member

keshav234156 commented Dec 19, 2019

Screenshot from 2019-12-19 09-03-43

@jywarren @harshkhandeparkar @dnhuan I just noticed this. It occurs due to this PR.@dnhuan Please do the required changes. @jywarren @harshkhandeparkar How can we prevent this type of bugs in the future?

@dnhuan
Copy link
Author

dnhuan commented Dec 19, 2019

Do you mean the positon of the “Add step” buttong being pushed down to another line? I will take a look at that in a minute.

@keshav234156
Copy link
Member

@dnhuan It should look like

Screenshot from 2019-12-19 09-24-09

@dnhuan
Copy link
Author

dnhuan commented Dec 19, 2019

I can confirm that this problem is caused by my patch. However, I am unable to generate the error locally, could you describe the steps taken to reproduce the problem?
gciimgseq

@keshav234156
Copy link
Member

keshav234156 commented Dec 19, 2019

@dnhuan this occurs in insert step not dropdown for add step.
First, add 2 steps. Then there would be an option of insert step. Click on it

@dnhuan
Copy link
Author

dnhuan commented Dec 19, 2019

Thank you, I am able to reproduce the problem. Turns out I shouldn't edit a global CSS. Currently trying to find a workaround.

@keshav234156
Copy link
Member

@dnhuan are you working on it?

@dnhuan
Copy link
Author

dnhuan commented Dec 31, 2019

Currently not, but will get back to it tonight. Sorry for the delay, I was busy finishing my finals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leftmost "resize quick button" not properly displayed.
4 participants