Change dimension upon loading an Image through UI

[ataata107]

Fixes #1391

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• ask @publiclab/is-reviewers for help, in a comment below
• Dimension change is working as expected

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

[codecov]

Codecov Report

Merging #1395 into main will decrease coverage by 0.01%.
The diff coverage is 25%.

@@            Coverage Diff             @@
##             main    #1395      +/-   ##
==========================================
- Coverage   66.36%   66.35%   -0.02%     
==========================================
  Files         125      125              
  Lines        2572     2574       +2     
  Branches      406      406              
==========================================
+ Hits         1707     1708       +1     
- Misses        865      866       +1

Impacted Files	Coverage Δ
examples/lib/defaultHtmlStepUi.js	11.29% <25%> (+0.44%)	⬆️

[ataata107]

@harshkhandeparkar @jywarren @keshav234156
Please do check this out. I will refactor it after your reviews.

[harshkhandeparkar]

Does this do the reloading? Instead, I think there should be a load image callback or even which could trigger just the dimensions function(or anything else if you want). What do you think?

[ataata107]

Yes you’re correct
By the way this doesn’t do reloading. This PR just triggers the dimension function as one loads an image.

[harshkhandeparkar]

Everything looks fine to me except for a few comments which I think you will fix soon.

[ataata107]

Sure

[ataata107]

@harshkhandeparkar removed the comments and refactored please review

[harshkhandeparkar]

Can this function be called updateDimensions? The current name may be misleading. Please add JSDoc description comment for the function too. Thanks!

[jywarren]

🎉