Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed redirect from '/' to reload the same page #1399

Merged
merged 2 commits into from Jan 1, 2020
Merged

changed redirect from '/' to reload the same page #1399

merged 2 commits into from Jan 1, 2020

Conversation

root00198
Copy link
Member

@root00198 root00198 commented Dec 27, 2019

Fixes #1394 (<=== Replace 0000 with the Issue Number)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@root00198
Copy link
Member Author

root00198 commented Dec 27, 2019

@publiclab/is-reviewers

@codecov
Copy link

codecov bot commented Dec 27, 2019

Codecov Report

Merging #1399 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1399   +/-   ##
=======================================
  Coverage   66.12%   66.12%           
=======================================
  Files         125      125           
  Lines        2571     2571           
  Branches      404      404           
=======================================
  Hits         1700     1700           
  Misses        871      871

Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for your help. I think what you did was perfect for this use case. But don't you think to add a new function could have helped in some other use cases?

@tsparksh
Copy link
Member

Hey @root00198, could you create a feature branch for the PR? This will allow you to work on multiple features at once, otherwise, you have to wait for the previous PR to be merged so that main becomes free for the new branch and so on.

@harshkhandeparkar
Copy link
Member

Let them start doing this from the next PR since this one is ready to be merged.

@ataata107 ataata107 mentioned this pull request Dec 29, 2019
5 tasks
@jywarren jywarren merged commit 772a569 into publiclab:main Jan 1, 2020
@welcome
Copy link

welcome bot commented Jan 1, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will be published to https://beta.sequencer.publiclab.org in a day or two.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

@jywarren
Copy link
Member

jywarren commented Jan 1, 2020

Thank you so much! This is great!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clear Steps Button Redirects to /
5 participants