Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug => Color Temperature showing black image when set on default. #1401

Merged
merged 3 commits into from Jan 2, 2020
Merged

Fixed bug => Color Temperature showing black image when set on default. #1401

merged 3 commits into from Jan 2, 2020

Conversation

root00198
Copy link
Member

@root00198 root00198 commented Dec 27, 2019

Fixes #1392 (<=== Replace 0000 with the Issue Number)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@root00198
Copy link
Member Author

as far as I can see the error in the travis ci build is Failed to install 10. Remote repository may not be reachable. I think it is not because of my code.

@root00198
Copy link
Member Author

root00198 commented Dec 28, 2019

@publiclab/is-reviewers

Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please load the default temperature from the info.json file? We have a util function than could help you here src/util/loadDefaults.js. Also, you don't need to add the === you can just write

options.temperature = options.temperature || defaults.temperature;

@codecov
Copy link

codecov bot commented Dec 29, 2019

Codecov Report

Merging #1401 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1401   +/-   ##
=======================================
  Coverage   66.16%   66.16%           
=======================================
  Files         125      125           
  Lines        2574     2574           
  Branches      406      406           
=======================================
  Hits         1703     1703           
  Misses        871      871

Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🚀! Thanks for your contribution.

@jywarren jywarren merged commit 6ffba53 into publiclab:main Jan 2, 2020
@jywarren
Copy link
Member

jywarren commented Jan 2, 2020

This is super!!! Thanks a lot!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color Temperature module doesn't work initially
3 participants