Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing module test #1410

Merged
merged 2 commits into from Jan 2, 2020
Merged

fixing module test #1410

merged 2 commits into from Jan 2, 2020

Conversation

keshav234156
Copy link
Member

Fixes #1376
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@keshav234156
Copy link
Member Author

@jywarren @harshkhandeparkar Please review the changes!!!

@codecov
Copy link

codecov bot commented Jan 2, 2020

Codecov Report

Merging #1410 into main will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1410      +/-   ##
==========================================
+ Coverage   66.12%   66.27%   +0.15%     
==========================================
  Files         125      125              
  Lines        2571     2571              
  Branches      404      404              
==========================================
+ Hits         1700     1704       +4     
+ Misses        871      867       -4
Impacted Files Coverage Δ
src/modules/ReplaceColor/ReplaceColor.js 92.3% <0%> (+15.38%) ⬆️

@jywarren
Copy link
Member

jywarren commented Jan 2, 2020

Whoa, does this resolve all the per-module tests? I see some edits but mostly changes in the expected output, i guess?

Should we add in the 1/0 status check here too?

@jywarren
Copy link
Member

jywarren commented Jan 2, 2020

Awesome, checked the logs. Looks great. I'll merge this now, let's do the status check in follow-up. Can you open an issue for it? Thanks!!!

@jywarren jywarren merged commit 7905cc9 into publiclab:main Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Module Tests
2 participants