Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing defaults in various modules #1441

Merged
merged 11 commits into from
Jan 7, 2020
Merged

Fixing defaults in various modules #1441

merged 11 commits into from
Jan 7, 2020

Conversation

root00198
Copy link
Member

@root00198 root00198 commented Jan 7, 2020

In various source modules, the default values are not set using the info.json file. Insted they are either set by hard coding or not set at all. In this PR I tried to fix all those modules.

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@codecov
Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #1441 into main will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main   #1441      +/-   ##
=========================================
+ Coverage   66.35%   66.4%   +0.05%     
=========================================
  Files         125     125              
  Lines        2574    2581       +7     
  Branches      406     410       +4     
=========================================
+ Hits         1708    1714       +6     
- Misses        866     867       +1
Impacted Files Coverage Δ
src/modules/Colormap/Colormap.js 90% <100%> (-3.11%) ⬇️
src/modules/FlipImage/Module.js 90% <100%> (+0.52%) ⬆️
src/modules/Threshold/Threshold.js 83.72% <100%> (ø) ⬆️
src/modules/Overlay/Module.js 100% <100%> (ø) ⬆️
src/modules/Colorbar/Module.js 100% <100%> (ø) ⬆️
src/modules/AddQR/Module.js 90.9% <100%> (ø) ⬆️
src/modules/ReplaceColor/ReplaceColor.js 92.59% <100%> (+0.28%) ⬆️

@root00198 root00198 changed the title Fixing defaults in the various modules Fixing defaults in various modules Jan 7, 2020
@root00198
Copy link
Member Author

@publiclab/is-reviewers

Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@jywarren jywarren merged commit d215b43 into publiclab:main Jan 7, 2020
@root00198 root00198 deleted the fixingDefaults branch January 8, 2020 02:50
@harshkhandeparkar harshkhandeparkar added this to Done in v3.6.0 Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v3.6.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants