Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw Rectangle default values #1443

Merged
merged 8 commits into from
Jan 17, 2020

Conversation

root00198
Copy link
Member

@root00198 root00198 commented Jan 8, 2020

There are no default values set for endx and endy in Draw Rectangle Module. In this PR I set thoses values as 10px as default.
Perviously, There will no rectangle by default. But now, There will be a rectangle(square) of 10x10 pixels.
BEFORE SETTING DEFAULTS
before

AFTER SETTING DEFAULTS
after

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@codecov
Copy link

codecov bot commented Jan 8, 2020

Codecov Report

❗ No coverage uploaded for pull request base (main@cfdbdad). Click here to learn what that means.
The diff coverage is 41.17%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1443   +/-   ##
=======================================
  Coverage        ?   66.62%           
=======================================
  Files           ?      129           
  Lines           ?     2661           
  Branches        ?      428           
=======================================
  Hits            ?     1773           
  Misses          ?      888           
  Partials        ?        0
Impacted Files Coverage Δ
src/modules/Blend/Module.js 61.01% <41.17%> (ø)

@root00198
Copy link
Member Author

@publiclab/is-reviewers

@jywarren
Copy link
Member

Hi, sorry but could you resolve the conflicts? Thank you!

@root00198
Copy link
Member Author

@jywarren, could you please review it...

@jywarren jywarren merged commit c703836 into publiclab:main Jan 17, 2020
@jywarren
Copy link
Member

Great work, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants