Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crop module #1463

Merged
merged 2 commits into from
Jan 13, 2020
Merged

Fix crop module #1463

merged 2 commits into from
Jan 13, 2020

Conversation

rishabhshuklax
Copy link
Member

@rishabhshuklax rishabhshuklax commented Jan 12, 2020

Fixes #1460

crop

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@codecov
Copy link

codecov bot commented Jan 12, 2020

Codecov Report

Merging #1463 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1463   +/-   ##
=======================================
  Coverage   64.88%   64.88%           
=======================================
  Files         127      127           
  Lines        2597     2597           
  Branches      418      418           
=======================================
  Hits         1685     1685           
  Misses        912      912

@rishabhshuklax
Copy link
Member Author

@publiclab/is-reviewers please review this

Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, although perhaps we should start to ask for a small test for any changes now, that we're doing really well on this stuff! Thank you !!!!!

@jywarren
Copy link
Member

This could even use a UI test!

@jywarren jywarren merged commit bfff7e7 into publiclab:main Jan 13, 2020
@jywarren
Copy link
Member

That would be great to protect your fix, what do you think?

@keshav234156
Copy link
Member

@jywarren @harshkhandeparkar @blurry-x-face just notice this bug caused due to this PR
Screenshot from 2020-01-14 08-05-08

@rishabhshuklax
Copy link
Member Author

Whoa! What happened just before this? I'll look into this immediately and fix this ASAP, thanks @keshav234156

@keshav234156
Copy link
Member

keshav234156 commented Jan 14, 2020

the black box should appear on image to be crop in crop step

@rishabhshuklax
Copy link
Member Author

🤔 I think I know why this might have happened, I'm sorry, I will fix this ASAP!

@rishabhshuklax
Copy link
Member Author

rishabhshuklax commented Jan 14, 2020

I tried findng but I am stuck, @keshav234156 do you have any idea what is going on here?

color-picker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v3.6.0
  
Done
Development

Successfully merging this pull request may close these issues.

Crop Module Not Producing Expected Output
4 participants