Fix color picker bug #1465
Fix color picker bug #1465
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1465 +/- ##
==========================================
- Coverage 64.78% 64.75% -0.03%
==========================================
Files 127 127
Lines 2601 2602 +1
Branches 418 418
==========================================
Hits 1685 1685
- Misses 916 917 +1
|
|
@publiclab/is-reviewers please review this. |
examples/lib/defaultHtmlStepUi.js
Outdated
| @@ -276,6 +276,21 @@ function DefaultHtmlStepUi(_sequencer, options) { | |||
| }); | |||
| }); | |||
|
|
|||
| $step('.color-picker-target').each(function(i, input) { | |||
There was a problem hiding this comment.
I am extremely sorry for asking you to change this to $step. It is supposed to be $stepAll otherwise, it won't work for multiple pickers.
Please change it again.
I am extremely sorry. I forgot what $stepAll does, for a moment.
There was a problem hiding this comment.
I thought so too that's why I used stepAll but when I changed it to step still it was working fine that's why I pushed commit.
There was a problem hiding this comment.
Sorry. Please revert it though.
|
@harshkhandeparkar Done. |
|
Same! Looks great! This could also use a UI test perhaps to protect it in the future! Thank you!!! |
|
@jywarren I've added the test for this! |
|
@harshkhandeparkar I've made the requested changes, Is this alright? |
|
Great work!! Thanks!! |
Fixes #1464
npm test@publiclab/is-reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!