Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contrast module now uses changePixel Method #1482

Merged
merged 7 commits into from Jan 16, 2020

Conversation

rishabhshuklax
Copy link
Member

Fixes #1472

Contrast module now uses changePixel Method instead of extraManipulation which has made it faster.

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@codecov
Copy link

codecov bot commented Jan 13, 2020

Codecov Report

Merging #1482 into main will decrease coverage by 0.09%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #1482     +/-   ##
=========================================
- Coverage   64.74%   64.64%   -0.1%     
=========================================
  Files         126      126             
  Lines        2590     2594      +4     
  Branches      416      416             
=========================================
  Hits         1677     1677             
- Misses        913      917      +4
Impacted Files Coverage Δ
examples/lib/insertPreview.js 13.51% <ø> (ø) ⬆️
examples/lib/defaultHtmlStepUi.js 10.98% <0%> (-0.25%) ⬇️

@rishabhshuklax
Copy link
Member Author

@publiclab/is-reviewers please review this

Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The test pass too.

@jywarren jywarren merged commit 94caefa into publiclab:main Jan 16, 2020
@jywarren
Copy link
Member

Great work!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contrast Module should use changePixel Method
3 participants