Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring isGIF() as a utility function #1511

Merged
merged 10 commits into from
Jan 17, 2020

Conversation

rishabhshuklax
Copy link
Member

@rishabhshuklax rishabhshuklax commented Jan 15, 2020

Fixes #1501

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@rishabhshuklax
Copy link
Member Author

@keshav234156 Do you know why UI tests are failing?
@harshkhandeparkar ?

@codecov
Copy link

codecov bot commented Jan 16, 2020

Codecov Report

Merging #1511 into main will increase coverage by 1.4%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #1511     +/-   ##
=========================================
+ Coverage   65.56%   66.97%   +1.4%     
=========================================
  Files         129      129             
  Lines        2628     2628             
  Branches      426      426             
=========================================
+ Hits         1723     1760     +37     
+ Misses        905      868     -37
Impacted Files Coverage Δ
src/util/ParseInputCoordinates.js 92.85% <0%> (-7.15%) ⬇️
src/modules/Channel/Module.js 93.75% <0%> (+6.25%) ⬆️
src/modules/ReplaceColor/ReplaceColor.js 100% <0%> (+7.4%) ⬆️
src/modules/ColorTemperature/Module.js 94.73% <0%> (+10.52%) ⬆️
src/util/getStep.js 25% <0%> (+14.28%) ⬆️
src/modules/Dither/Dither.js 76.74% <0%> (+18.6%) ⬆️
src/modules/FlipImage/flipImage.js 100% <0%> (+20%) ⬆️
src/modules/NoiseReduction/NoiseReduction.js 100% <0%> (+34.78%) ⬆️

@rishabhshuklax
Copy link
Member Author

@publiclab/is-reviewers please review this

@jywarren
Copy link
Member

Hmm, this is showing up oddly in my interface. Maybe GitHub UI changed? Can you rebase this, it's not offering me an easy button to do so myself!

Thank you! this is great.

@rishabhshuklax
Copy link
Member Author

@jywarren Done!

@jywarren jywarren merged commit 1fa8c6b into publiclab:main Jan 17, 2020
@jywarren
Copy link
Member

Great! Thank you!!!

@rishabhshuklax rishabhshuklax deleted the isGif-refactor branch January 17, 2020 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactoring isGIF() as a utility function
3 participants