Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant AddQR function #1532

Merged
merged 5 commits into from
Jan 22, 2020

Conversation

ovsundal
Copy link

@ovsundal ovsundal commented Jan 17, 2020

Fixes #1498 Redundant changePixel Function

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@codecov
Copy link

codecov bot commented Jan 17, 2020

Codecov Report

Merging #1532 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1532   +/-   ##
=======================================
  Coverage   66.61%   66.61%           
=======================================
  Files         130      130           
  Lines        2672     2672           
  Branches      430      430           
=======================================
  Hits         1780     1780           
  Misses        892      892

@ovsundal
Copy link
Author

does this look okay?

@ataata107
Copy link

Have you checked other modules too instead of AddQr?

@ovsundal
Copy link
Author

Not sure i understand what you mean?

@ovsundal
Copy link
Author

Trying to merge the pull request, but i'm not authorized. How do i proceed?

@harshkhandeparkar
Copy link
Member

@jywarren will merge your PR.

@jywarren jywarren merged commit 2378a67 into publiclab:main Jan 22, 2020
@welcome
Copy link

welcome bot commented Jan 22, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will be published to https://beta.sequencer.publiclab.org in a day or two.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

@jywarren
Copy link
Member

Great! Finally merged!!!

@jywarren
Copy link
Member

Thank you!! 🎉

@ataata107
Copy link

@jywarren This PR has broke Add-QR Module. Don't know why this happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redundant changePixel Function
4 participants