[FIXED] travis test not failing when module test fails #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis build is now failing and that is good sign... @publiclab/is-reviewers @jywarren @harshkhandeparkar @blurry-x-face |
jywarren
reviewed
Jan 21, 2020
|
OK, this should be ready to rebase now! |
|
Add Qr Module is failing for some reason... It is not failing in node version 8. |
Codecov Report
@@ Coverage Diff @@
## main #1550 +/- ##
=========================================
- Coverage 66.8% 66.64% -0.17%
=========================================
Files 129 130 +1
Lines 2672 2674 +2
Branches 430 430
=========================================
- Hits 1785 1782 -3
- Misses 887 892 +5
|
|
This is a problem related to looks-same, I think, because sometimes it also fails locally but when running the test script again It passes 😕 #1536 |
|
That's the issue... I restarted the build though... let's see what happens... It will pass this time. |
|
Yay! Are we good to merge this then? Super great work! |
jywarren
approved these changes
Jan 21, 2020
|
Thanks, everyone! |
This was referenced Jan 21, 2020
2 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, I tried to fix the issue when travis-ci-test shows, green tick even though the module test failed.
In order to fix this issue, I tried to create a test repo and setup travis in that.
Below are two travis build result, one passed and one failed. The only difference between those two builds is that, insted of putting all the test in one line, I mentioned them on seperate lines, and then asked travis to execute all the commands one-by-one.
https://travis-ci.org/root00198/travis-test/builds/640046449 <<- BUILD THAT PASSES
https://travis-ci.org/root00198/travis-test/builds/640047387 <<- BUILD THAT FAILED
Check the diff between these two build... https://github.com/root00198/travis-test/compare/a808664ba5f7...3a1042fd1bdd