Refactored resize

[rishabhshuklax]

Concerns #1560

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm run test-all
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• ask @publiclab/is-reviewers for help, in a comment below
• Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

[codecov]

Codecov Report

Merging #1562 into main will increase coverage by 10.31%.
The diff coverage is 64.01%.

@@             Coverage Diff             @@
##             main    #1562       +/-   ##
===========================================
+ Coverage   55.11%   65.43%   +10.31%     
===========================================
  Files         117      133       +16     
  Lines        2344     2743      +399     
  Branches      360      438       +78     
===========================================
+ Hits         1292     1795      +503     
+ Misses       1052      948      -104     

Impacted Files	Coverage Δ
examples/lib/scopeQuery.js	18.51% <ø> (ø)
src/Modules.js	100.00% <ø> (ø)
src/modules/WebglDistort/Module.js	2.29% <0.00%> (ø)
src/ui/SetInputStep.js	12.90% <0.00%> (-1.39%)	⬇️
src/modules/ColorHalftone/Module.js	3.63% <3.63%> (ø)
examples/lib/defaultHtmlStepUi.js	11.35% <4.08%> (-0.85%)	⬇️
examples/lib/intermediateHtmlStepUi.js	11.11% <5.55%> (+0.94%)	⬆️
examples/lib/insertPreview.js	13.15% <20.00%> (-0.36%)	⬇️
src/util/getImageDimensions.js	20.00% <20.00%> (ø)
src/util/isGif.js	20.00% <20.00%> (ø)
... and 102 more

[rishabhshuklax]

@publiclab/is-reviewers

[gitpod-io]

[jywarren]

Just needs a quick test in gitpod or a module test to confirm! Thanks and apologies for the delay!

[harshkhandeparkar]

The refactor is fine but I did find an issue in the resize module itself...

[jywarren]

Hi harsh, I had requested a module test for this, just FYI... Can you be careful to check the comments before merging? Thanks!!

[harshkhandeparkar]

Isn't there a test for it already 👀? The review was an approval so I thought... 😅
Sorry.

[harshkhandeparkar]

And I did check everything in gitpod, now and also sometime back when I had reviewed it :)
Also, the resize module has a test.

[jywarren]

OK, thanks, good to hear! no problem. I'll be more careful of approve vs. comment now we are co-maintainers!