-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored resize #1562
Refactored resize #1562
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1562 +/- ##
===========================================
+ Coverage 55.11% 65.43% +10.31%
===========================================
Files 117 133 +16
Lines 2344 2743 +399
Branches 360 438 +78
===========================================
+ Hits 1292 1795 +503
+ Misses 1052 948 -104
|
@publiclab/is-reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just needs a quick test in gitpod or a module test to confirm! Thanks and apologies for the delay!
The refactor is fine but I did find an issue in the resize module itself... |
Hi harsh, I had requested a module test for this, just FYI... Can you be careful to check the comments before merging? Thanks!! |
Isn't there a test for it already 👀? The review was an approval so I thought... 😅 |
And I did check everything in gitpod, now and also sometime back when I had reviewed it :) |
OK, thanks, good to hear! no problem. I'll be more careful of approve vs. comment now we are co-maintainers! |
Concerns #1560
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm run test-all
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!