-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated config.yml according to plots2 file #1566
Conversation
Thanks for opening this pull request! |
@publiclab/reviewers Please review this. |
Codecov Report
@@ Coverage Diff @@
## main #1566 +/- ##
===========================================
+ Coverage 55.11% 65.41% +10.29%
===========================================
Files 117 132 +15
Lines 2344 2741 +397
Branches 360 438 +78
===========================================
+ Hits 1292 1793 +501
+ Misses 1052 948 -104
|
Sure will do it.
…On Thu, Jan 23, 2020, 7:32 PM Rishabh Shukla ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In .github/config.yml
<#1566 (comment)>
:
> @@ -4,22 +4,27 @@
# Comment to be posted to on first time issues
newIssueWelcomeComment: |
- Thanks for opening your first issue here! Please follow the issue template to help us help you 👍🎉😄
- If you have screenshots to share demonstrating the issue, that's really helpful! 📸 You can [make a gif](https://www.cockos.com/licecap/) too!
+ Thanks for opening your first issue here! This space is [protected by our Code of Conduct](https://publiclab.org/conduct) - and we're here to help.
+ Please follow the issue template to help us help you 👍🎉😄
+ If you have screenshots to share demonstrating the issue, that's really helpful! 📸 You can [make a gif](https://www.cockos.com/licecap/) too!
+ Don't forget to join our [Gitter channel](https://gitter.im/publiclab/publiclab) for some brainstorming discussions.
IS has its own gitter channel https://gitter.im/publiclab/image-sequencer
you can add this too here!
------------------------------
In .github/config.yml
<#1566 (comment)>
:
> # Configuration for new-pr-welcome - https://github.com/behaviorbot/new-pr-welcome
# Comment to be posted to on PRs from first time contributors in your repository
newPRWelcomeComment: |
- Thanks for opening this pull request!
- There may be some errors, **but don't worry!** We're here to help! 👍🎉😄
+ Thanks for opening this pull request! This space is [protected by our Code of Conduct](https://publiclab.org/conduct).
+ `Dangerbot` will test out your code and reply in a bit with some pointers and requests.There may be some errors, **but don't worry!** We're here to help! 👍🎉😄
I don't think we use danger bot, so probably you can remove this, instea
add this
There may be some errors, **but don't worry!** We're here to help! 👍🎉😄
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1566?email_source=notifications&email_token=AKSNXKZVSBZTIHDLWSZSMYTQ7GPPXA5CNFSM4KKWRURKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSZZUDQ#pullrequestreview-347314702>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKSNXK5PBVGXA3LY4AUQH33Q7GPPXANCNFSM4KKWRURA>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set two.Please
to two. Please
(Missing Space)
At line 23
@LeoDog896 Done!! Please review it again |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @sharmamansi!
Congrats on merging your first pull request! 🙌🎉⚡️ |
Thank you. |
Fixes #1311
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm run test-all
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!