preview optimization #1573
Merged
preview optimization #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1573 +/- ##
=======================================
Coverage 66.67% 66.67%
=======================================
Files 130 130
Lines 2686 2686
Branches 433 433
=======================================
Hits 1791 1791
Misses 895 895 |
|
@jywarren can you please review the changes!! |
|
Hi, cool! I'm not sure we do any testing for this, so would you mind sharing a gif? Thanks a ton! |
|
And/or a test, actually 😄 |
|
https://drive.google.com/file/d/1mULwSsFRxEM0f9RNRC34s9A6F78M1GON/view @jywarren Here is the effect of changes on preview!! |
|
@jywarren I must say that you are now better at managing your notification!!! |
|
Well, i have more time today, but i'm not sure I can keep it up! |
jywarren
approved these changes
Jan 28, 2020
|
Great! Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1184
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm run test-all@publiclab/is-reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!