Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Setup Script Typo #1588

Merged
merged 5 commits into from
Jan 28, 2020
Merged

Fixed Setup Script Typo #1588

merged 5 commits into from
Jan 28, 2020

Conversation

harshkhandeparkar
Copy link
Member

Fixes #0000 (<=== Replace 0000 with the Issue Number)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm run test-all
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@harshkhandeparkar harshkhandeparkar requested a review from a team January 28, 2020 16:01
@harshkhandeparkar
Copy link
Member Author

This could fix a lot of installation issues that people have been facing.

@harshkhandeparkar
Copy link
Member Author

@jywarren

@jywarren
Copy link
Member

Can you explain what happens? Looks good to me, but want to be careful!

@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #1588 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1588   +/-   ##
=======================================
  Coverage   66.61%   66.61%           
=======================================
  Files         130      130           
  Lines        2672     2672           
  Branches      430      430           
=======================================
  Hits         1780     1780           
  Misses        892      892

@harshkhandeparkar
Copy link
Member Author

harshkhandeparkar commented Jan 28, 2020 via email

Copy link
Member

@rishabhshuklax rishabhshuklax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should solve many of the installation issues that we've been getting lately!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants