Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed all instances of mode: 'test' #1599

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Removed all instances of mode: 'test' #1599

merged 1 commit into from
Jan 31, 2020

Conversation

Deogle
Copy link

@Deogle Deogle commented Jan 30, 2020

Fixes #1516

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm run test-all
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

Note: I removed instances in commented out tests as well. Not sure if necessary, but I wanted to be sure to cover all the bases :)

@welcome
Copy link

welcome bot commented Jan 30, 2020

Thanks for opening this pull request!
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

Merging #1599 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1599   +/-   ##
=======================================
  Coverage   66.67%   66.67%           
=======================================
  Files         130      130           
  Lines        2686     2686           
  Branches      433      433           
=======================================
  Hits         1791     1791           
  Misses        895      895

Copy link
Member

@rishabhshuklax rishabhshuklax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, Nice work 🎉

@jywarren jywarren merged commit 600cce0 into publiclab:main Jan 31, 2020
@welcome
Copy link

welcome bot commented Jan 31, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will be published to https://beta.sequencer.publiclab.org in a day or two.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

@jywarren
Copy link
Member

Super, great work!!

@Deogle Deogle deleted the remove-mode-test branch February 3, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove All Instances of mode: 'test'
3 participants