Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for transparent image in overlay module #1606

Merged
merged 6 commits into from
Nov 1, 2020

Conversation

rishabhshuklax
Copy link
Member

@rishabhshuklax rishabhshuklax commented Feb 1, 2020

Fixes #1605

Screenshot from 2020-02-01 17-10-37

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm run test-all
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@rishabhshuklax
Copy link
Member Author

@publiclab/is-reviewers please review this

@codecov
Copy link

codecov bot commented Feb 1, 2020

Codecov Report

Merging #1606 into main will decrease coverage by 1.21%.
The diff coverage is 47.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1606      +/-   ##
==========================================
- Coverage   66.67%   65.46%   -1.22%     
==========================================
  Files         130      133       +3     
  Lines        2686     2748      +62     
  Branches      433      440       +7     
==========================================
+ Hits         1791     1799       +8     
- Misses        895      949      +54     
Impacted Files Coverage Δ
src/Modules.js 100.00% <ø> (ø)
src/modules/EdgeDetect/Module.js 100.00% <ø> (ø)
src/modules/WebglDistort/Module.js 2.29% <0.00%> (ø)
src/modules/ColorHalftone/Module.js 3.63% <3.63%> (ø)
src/modules/Overlay/Module.js 93.18% <94.11%> (-1.69%) ⬇️
src/modules/ColorHalftone/index.js 100.00% <100.00%> (ø)
src/modules/Colorbar/Module.js 100.00% <100.00%> (ø)
src/modules/Crop/Module.js 88.88% <100.00%> (ø)
src/modules/EdgeDetect/EdgeUtils.js 86.81% <100.00%> (-0.15%) ⬇️
src/modules/Resize/Module.js 100.00% <100.00%> (ø)
... and 4 more

@rishabhshuklax rishabhshuklax mentioned this pull request Feb 1, 2020
5 tasks
@gitpod-io
Copy link

gitpod-io bot commented Jul 7, 2020

Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All hail ES6,7.8.9.10 and even soon to come 11!

@rishabhshuklax
Copy link
Member Author

@jywarren could review this too!

@jywarren jywarren added this to the v3.7.0 milestone Oct 28, 2020
@jywarren jywarren requested a review from a team as a code owner November 1, 2020 16:16
@jywarren jywarren merged commit 0622a0c into publiclab:main Nov 1, 2020
@jywarren
Copy link
Member

jywarren commented Nov 1, 2020

Thanks folks! Great to be moving again, thanks for all your help!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overlay doesn't work correctly with transparent image
3 participants