update gitpod conf to main branch? #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
5 tasks
Codecov Report
@@ Coverage Diff @@
## main #1680 +/- ##
=======================================
Coverage 65.42% 65.42%
=======================================
Files 132 132
Lines 2742 2742
Branches 438 438
=======================================
Hits 1794 1794
Misses 948 948 |
|
Hmm. @nisarhassan12 do you think this was wrong? I tried to ask a clarifying question in gitpod-io/gitpod#1646 but am not sure if i should revert this. Thanks for your help! |
|
Oops misspelled @nisarhassan12 apologies. Corrected above, thank you! |
jywarren
added a commit
that referenced
this pull request
Jul 6, 2020
|
Undid this! ef3afc0 following suggestions from gitpod-io/gitpod#1646 I just removed the whole line bc prebuilds are on by default. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this passes, we might also set up the default test in GitPod to add all modules, and a smaller image, so we get to see it run through all modules by default!