Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split tests into separate Travis jobs with better labeling #1684

Merged
merged 5 commits into from
Jul 7, 2020
Merged

Conversation

jywarren
Copy link
Member

@jywarren jywarren commented Jul 6, 2020

No description provided.

@gitpod-io
Copy link

gitpod-io bot commented Jul 6, 2020

@codecov
Copy link

codecov bot commented Jul 6, 2020

Codecov Report

Merging #1684 into main will increase coverage by 10.30%.
The diff coverage is 63.75%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1684       +/-   ##
===========================================
+ Coverage   55.11%   65.42%   +10.30%     
===========================================
  Files         117      132       +15     
  Lines        2344     2742      +398     
  Branches      360      438       +78     
===========================================
+ Hits         1292     1794      +502     
+ Misses       1052      948      -104     
Impacted Files Coverage Δ
examples/lib/scopeQuery.js 18.51% <ø> (ø)
src/Modules.js 100.00% <ø> (ø)
src/modules/WebglDistort/Module.js 2.29% <0.00%> (ø)
src/ui/SetInputStep.js 12.90% <0.00%> (-1.39%) ⬇️
src/modules/ColorHalftone/Module.js 3.63% <3.63%> (ø)
examples/lib/defaultHtmlStepUi.js 11.35% <4.08%> (-0.85%) ⬇️
examples/lib/intermediateHtmlStepUi.js 11.11% <5.55%> (+0.94%) ⬆️
examples/lib/insertPreview.js 13.15% <20.00%> (-0.36%) ⬇️
src/util/getImageDimensions.js 20.00% <20.00%> (ø)
src/util/isGif.js 20.00% <20.00%> (ø)
... and 100 more

@jywarren
Copy link
Member Author

jywarren commented Jul 6, 2020

Hmm. Much more readable, though!

0.40s$ npm run core-tests
> image-sequencer@3.5.1 core-tests /home/travis/build/publiclab/image-sequencer
> cat ./output/core-tests.js | tape-run --render="tap-spec"
cat: ./output/core-tests.js: No such file or directory
internal/streams/legacy.js:59
      throw er; // Unhandled stream error in pipe.
      ^

@jywarren
Copy link
Member Author

jywarren commented Jul 6, 2020

image

@jywarren
Copy link
Member Author

jywarren commented Jul 7, 2020

Got it. The browserify tests step has an output which is then used in the subsequent test run, so we can't separate those two.

@jywarren
Copy link
Member Author

jywarren commented Jul 7, 2020

Nice!!! cc @publiclab/image-sequencer-guides @publiclab/is-reviewers Separating out and labeling our tests for readability!!! 🎉

@jywarren jywarren merged commit 102b82b into main Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant