Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CODEOWNERS #1719

Merged
merged 6 commits into from
Oct 14, 2020
Merged

Create CODEOWNERS #1719

merged 6 commits into from
Oct 14, 2020

Conversation

harshkhandeparkar
Copy link
Member

@harshkhandeparkar harshkhandeparkar commented Oct 14, 2020

Fixes #1633

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm run test-all
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@gitpod-io
Copy link

gitpod-io bot commented Oct 14, 2020

@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #1719 into main will decrease coverage by 1.26%.
The diff coverage is 12.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1719      +/-   ##
==========================================
- Coverage   66.67%   65.41%   -1.27%     
==========================================
  Files         130      132       +2     
  Lines        2686     2741      +55     
  Branches      433      438       +5     
==========================================
+ Hits         1791     1793       +2     
- Misses        895      948      +53     
Impacted Files Coverage Δ
src/Modules.js 100.00% <ø> (ø)
src/modules/EdgeDetect/Module.js 100.00% <ø> (ø)
src/modules/WebglDistort/Module.js 2.29% <0.00%> (ø)
src/modules/ColorHalftone/Module.js 3.63% <3.63%> (ø)
src/modules/ColorHalftone/index.js 100.00% <100.00%> (ø)
src/modules/EdgeDetect/EdgeUtils.js 86.81% <100.00%> (-0.15%) ⬇️

Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, added some ideas, but the precedence thing is a little weird. What do you think?

if a PR modifies both a test/core directory and a core file, would both get notified?

harshkhandeparkar and others added 3 commits October 14, 2020 21:18
Co-authored-by: Jeffrey Warren <jeff@unterbahn.com>
Co-authored-by: Jeffrey Warren <jeff@unterbahn.com>
Co-authored-by: Jeffrey Warren <jeff@unterbahn.com>
@harshkhandeparkar
Copy link
Member Author

I committed your changes @jywarren.

@jywarren
Copy link
Member

Ah, i'm seeing the electron download issue that's also in #1718 -- cc @daemon1024 that this is system-wide, its probably the link is no longer good for the .zip download:

Error: GET https://github.com/electron/electron/releases/download/v5.0.13/electron-v5.0.13-linux-x64.zip returned 429

https://travis-ci.com/github/publiclab/image-sequencer/jobs/399672398#L668

we should try resolving this and it may unblock both PRs.

@jywarren
Copy link
Member

@jywarren
Copy link
Member

Could this be linked to #55 (comment) with tape-run?

We recently upgrade to tape-run v7, let's try to go to v8 which will rely on a more recent version of electron:

#1662

@harshkhandeparkar
Copy link
Member Author

Maybe a bump? puppeteer version bump might work?

@jywarren
Copy link
Member

I just bumped dependabot, but don't see anything yet...

@harshkhandeparkar
Copy link
Member Author

Electron downloads are always weird...

@jywarren
Copy link
Member

ok, tape-run v8 installed!

@jywarren
Copy link
Member

OK, let's do it!

@jywarren jywarren merged commit 8e3abcc into main Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Feature maintainers" groups to collaboratively manage IS
2 participants