Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse floating-point value from percentages #1733

Merged
merged 4 commits into from
Nov 2, 2020

Conversation

adzo261
Copy link

@adzo261 adzo261 commented Oct 18, 2020

Fixes #1725

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm run test-all
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@adzo261 adzo261 requested a review from a team as a code owner October 18, 2020 17:05
@welcome
Copy link

welcome bot commented Oct 18, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct.
There may be some errors, but don't worry! We're here to help! 👍🎉😄
Also please refer (https://github.com/publiclab/image-sequencer/blob/main/README.md) for installation help.

@gitpod-io
Copy link

gitpod-io bot commented Oct 18, 2020

@codecov
Copy link

codecov bot commented Oct 18, 2020

Codecov Report

Merging #1733 into main will decrease coverage by 1.21%.
The diff coverage is 47.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1733      +/-   ##
==========================================
- Coverage   66.67%   65.46%   -1.22%     
==========================================
  Files         130      133       +3     
  Lines        2686     2748      +62     
  Branches      433      440       +7     
==========================================
+ Hits         1791     1799       +8     
- Misses        895      949      +54     
Impacted Files Coverage Δ
src/Modules.js 100.00% <ø> (ø)
src/modules/EdgeDetect/Module.js 100.00% <ø> (ø)
src/modules/WebglDistort/Module.js 2.29% <0.00%> (ø)
src/modules/ColorHalftone/Module.js 3.63% <3.63%> (ø)
src/modules/Overlay/Module.js 93.18% <94.11%> (-1.69%) ⬇️
src/modules/ColorHalftone/index.js 100.00% <100.00%> (ø)
src/modules/Colorbar/Module.js 100.00% <100.00%> (ø)
src/modules/Crop/Module.js 88.88% <100.00%> (ø)
src/modules/EdgeDetect/EdgeUtils.js 86.81% <100.00%> (-0.15%) ⬇️
src/modules/Resize/Module.js 100.00% <100.00%> (ø)
... and 4 more

@harshkhandeparkar harshkhandeparkar added this to In Progress in v3.7.0 via automation Oct 18, 2020
@harshkhandeparkar
Copy link
Member

Would you mind adding a test for this?

@adzo261
Copy link
Author

adzo261 commented Oct 19, 2020

Sure. Will do it.

@adzo261 adzo261 requested a review from a team as a code owner October 22, 2020 15:05
@jywarren jywarren added this to the v3.7.0 milestone Oct 28, 2020
@harshkhandeparkar harshkhandeparkar removed this from the v3.7.0 milestone Nov 2, 2020
Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests! Thank you!!!

@jywarren jywarren merged commit 893bc10 into publiclab:main Nov 2, 2020
v3.7.0 automation moved this from In Progress to Done Nov 2, 2020
@welcome
Copy link

welcome bot commented Nov 2, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will be published to https://beta.sequencer.publiclab.org in a day or two. Please test out your work on this testing server and report back with a comment that all has gone well!
In the meantime, can you tell us your Twitter handle so we can thank you properly also do join our weekly check-in to share your this week goal and the awesome work you did 😃.
Please find the link pinned in the issue section
Now that you've completed this, you can help someone else take their first step! Try looking at this list of first-timers-only issues, and see if someone else is waiting for feedback, or even stuck! 😕
People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉
See: Public Lab's coding community!

@harshkhandeparkar
Copy link
Member

Pinned issue section? I guess this is specific for plots2, isn't it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
v3.7.0
  
Done
Development

Successfully merging this pull request may close these issues.

Better method of parsing %ages
3 participants