Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts to update gh-pages #1739

Merged
merged 10 commits into from
Oct 28, 2020
Merged

Scripts to update gh-pages #1739

merged 10 commits into from
Oct 28, 2020

Conversation

harshkhandeparkar
Copy link
Member

Fixes #0000 (<=== Replace 0000 with the Issue Number)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm run test-all
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@gitpod-io
Copy link

gitpod-io bot commented Oct 23, 2020

@harshkhandeparkar
Copy link
Member Author

I haven't tested it yet though. I changed a few things in it.

@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #1739 into main will decrease coverage by 1.23%.
The diff coverage is 38.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1739      +/-   ##
==========================================
- Coverage   66.67%   65.43%   -1.24%     
==========================================
  Files         130      133       +3     
  Lines        2686     2743      +57     
  Branches      433      439       +6     
==========================================
+ Hits         1791     1795       +4     
- Misses        895      948      +53     
Impacted Files Coverage Δ
src/Modules.js 100.00% <ø> (ø)
src/modules/EdgeDetect/Module.js 100.00% <ø> (ø)
src/modules/WebglDistort/Module.js 2.29% <0.00%> (ø)
src/modules/ColorHalftone/Module.js 3.63% <3.63%> (ø)
src/modules/ColorHalftone/index.js 100.00% <100.00%> (ø)
src/modules/Colorbar/Module.js 100.00% <100.00%> (ø)
src/modules/Crop/Module.js 88.88% <100.00%> (ø)
src/modules/EdgeDetect/EdgeUtils.js 86.81% <100.00%> (-0.15%) ⬇️
src/modules/Resize/Module.js 100.00% <100.00%> (ø)
src/modules/Resize/Resize.js 100.00% <100.00%> (ø)
... and 3 more

@harshkhandeparkar harshkhandeparkar requested a review from a team as a code owner October 23, 2020 19:16
@harshkhandeparkar harshkhandeparkar changed the title Create update-gh-pages script Scripts to update gh-pages Oct 26, 2020
@harshkhandeparkar
Copy link
Member Author

@publiclab/is-reviewers I just changed the script, split it into two parts. One script is for manually updating gh-pages and the other is for use in a GitHub action and is also used in the manual script. I also added docs for the same :)

@harshkhandeparkar
Copy link
Member Author

I tested it on my fork and it completed w/o any errors.

@@ -44,6 +44,7 @@
/*.lock @ubliclab/is-maintainers
/Gruntfile.js @publiclab/is-maintainers
/.github/ @publiclab/is-maintainers
/scripts/ @publiclab/is-maintainers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@jywarren
Copy link
Member

Trying this out now to publish to our own main demo!

@jywarren
Copy link
Member

Just used this! It worked!!!

@jywarren jywarren merged commit 099e7e2 into main Oct 28, 2020
@jywarren
Copy link
Member

awesomeeeeeeee.....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants