Upgrade picomatch so image-sequencer works in Safari

[jlev]

for #1738

Fixes #1738

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm run test-all
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• ask @publiclab/is-reviewers for help, in a comment below
• Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

[welcome]

Thanks for opening this pull request! This space is protected by our Code of Conduct.
There may be some errors, but don't worry! We're here to help! 👍🎉😄
Also please refer (https://github.com/publiclab/image-sequencer/blob/main/README.md) for installation help.

[gitpod-io]

[jlev]

Had one failed test locally, not sure if that's due to building on a Mac...

  Failed Tests: There was 1 failure

    convolution module works correctly

      ✖ convolution module works correctly with Gif

[codecov]

Codecov Report

Merging #1740 into main will decrease coverage by 1.79%.
The diff coverage is 46.48%.

@@            Coverage Diff             @@
##             main    #1740      +/-   ##
==========================================
- Coverage   66.67%   64.88%   -1.80%     
==========================================
  Files         130      135       +5     
  Lines        2686     2828     +142     
  Branches      433      458      +25     
==========================================
+ Hits         1791     1835      +44     
- Misses        895      993      +98     

Impacted Files	Coverage Δ
src/Modules.js	100.00% <ø> (ø)
src/modules/EdgeDetect/Module.js	100.00% <ø> (ø)
src/modules/WebglDistort/Module.js	2.29% <0.00%> (ø)
src/modules/ColorHalftone/Module.js	3.63% <3.63%> (ø)
src/modules/Shadow/Module.js	44.30% <44.30%> (ø)
src/modules/Overlay/Module.js	93.18% <94.11%> (-1.69%)	⬇️
src/modules/ColorHalftone/index.js	100.00% <100.00%> (ø)
src/modules/Colorbar/Module.js	100.00% <100.00%> (ø)
src/modules/Crop/Module.js	88.88% <100.00%> (ø)
src/modules/EdgeDetect/EdgeUtils.js	86.81% <100.00%> (-0.15%)	⬇️
... and 8 more

[jywarren]

Nice!

[jywarren]

Looks great, thanks Josh!!!

[jywarren]

Feel free to merge this, @publiclab/is-maintainers !

[harshkhandeparkar]

No, just a single suggestion isn't sufficient. We'll have to delete using npm only. We ARE NOT supposed to handle lockfiles and doing anything like that will only lead to disaster. (according to npm ig)

[jywarren]

OK, want to try this out using GitPod or otherwise push a commit to this branch? I'm not that familiar with changing just the lockfile as I usually let Dependabot handle those.

…

On Mon, Nov 2, 2020 at 12:07 PM Harsh Khandeparkar ***@***.***> wrote: No, just a single suggestion isn't sufficient. We'll have to delete using npm only. We ARE NOT supposed to handle lockfiles and doing anything like that will only lead to disaster. (according to npm ig) — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#1740 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAF6J3A4KX7V6W5QRPTZ23SN3RNZANCNFSM4TAAVKEQ> .

[harshkhandeparkar]

I can remove the dependency, one sec.
radio voice: initiating gitpod
radio: igniting in t - forever
(Gitpod really does take forever 😂)

[harshkhandeparkar]

Gitpod isn't allowing me to push, but npm uninstall picomatch does the job. I also checked the diff, apparently there is only one line that was changed in the lockfile(by jlev) and that remains. So just removing that one line from package.json works :)

[welcome]

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will be published to https://beta.sequencer.publiclab.org in a day or two. Please test out your work on this testing server and report back with a comment that all has gone well!
In the meantime, can you tell us your Twitter handle so we can thank you properly also do join our weekly check-in to share your this week goal and the awesome work you did 😃.
Please find the link pinned in the issue section
Now that you've completed this, you can help someone else take their first step! Try looking at this list of first-timers-only issues, and see if someone else is waiting for feedback, or even stuck! 😕
People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉
See: Public Lab's coding community!

[jywarren]

Done! Nice and many thanks to @jlev !!