refactor cli code

[daemon1024]

Ref #1747

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm run test-all
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• ask @publiclab/is-reviewers for help, in a comment below
• Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

[gitpod-io]

[harshkhandeparkar]

Are these the only options? What if they are changed in the future? Can it be dynamically loaded from the sequencer file?

[daemon1024]

I will have to look into it. It seems like the options are manually defined in index.js.

[harshkhandeparkar]

O:+1:

[jywarren]

Yes, it does seem like we're almost rebuilding the CLI in order to test the CLI here. Maybe we need cliTest() to accept an argument and use it in each test with just cliTest('--save-sequence [string]') -- so that we can see the scope of each test? Or something like that...

[daemon1024]

I refactored the entire program into another file. Hopefully this makes more sense and will make it easy to test, since we will get exactly the output that cli would do and no need to mimic them repetitively.

cc @jywarren @harshkhandeparkar

[daemon1024]

I will revert the commit, if this is out of scope of this PR, or may need to retitle the PR.

[harshkhandeparkar]

Can we put it inside src/ so that there is only one index.js to look at, to make it less confusing?

[daemon1024]

codeclimate failing 🤔 will have to refactor the code.

I wonder why it wasn't complaining earlier when the same code was in index.js

[daemon1024]

So it wasn't exclusive to module.exports 😓

[harshkhandeparkar]

It was probably failing before too but was ignored.

[daemon1024]

🥳

[jywarren]

Oh wow! I hope to have time to review in the next few days. In the meantime, i appreciate reviews from anyone else, thank you!!!

[jywarren]

Nice!!!!!! Thanks all!!! 🔥🔥🔥