adjust gitpod settings to be able to run jest tests in gitpod #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jywarren
changed the title
| @@ -3,5 +3,61 @@ FROM gitpod/workspace-full | |||
| USER root | |||
| RUN sudo apt-get update && apt-get install -y apt-transport-https \ | |||
| && sudo apt-get install -y \ | |||
| xserver-xorg-dev libxext-dev libxi-dev build-essential libxi-dev libglu1-mesa-dev libglew-dev pkg-config libglu1-mesa-dev freeglut3-dev mesa-common-dev \ | |||
| xserver-xorg-dev \ | |||
There was a problem hiding this comment.
We need so many? 🙀
Gitpod already takes a very long time to start...
There was a problem hiding this comment.
the first time -- after that it should be able to re-use the prebuilt container. I got this list from docs here (sorry should have linked):
if you find any we can skip, that'd be great, but it's pretty painstaking to try over and over! Thanks!
jywarren
added a commit
to publiclab/PublicLab.Editor
that referenced
this pull request
Jan 27, 2021
jywarren
added a commit
to publiclab/PublicLab.Editor
that referenced
this pull request
Jan 27, 2021
* Try running tests in GitHub Actions * Update tests.yml * tweaks and switch to grunt-contrib-jasmine v2.0.0 * add prereqs for Chrome Headless see publiclab/image-sequencer#1798 * jest tweaks * running! only 3 failing tests * getting closer * fix jest tests * Update Gruntfile.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #0000 (<=== Replace
0000with the Issue Number)Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm run test-all@publiclab/is-reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!