Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved way of displaying docs link #1799

Merged
merged 4 commits into from
Feb 6, 2021
Merged

Conversation

vivek-30
Copy link

@vivek-30 vivek-30 commented Feb 1, 2021

Fixes #1526

@vivek-30 vivek-30 requested a review from a team as a code owner February 1, 2021 16:45
@gitpod-io
Copy link

gitpod-io bot commented Feb 1, 2021

@vivek-30
Copy link
Author

vivek-30 commented Feb 1, 2021

apologies for the blunder 😅

@harshkhandeparkar
Copy link
Member

Even Linus Torvalds(creator of git) must have made mistakes in committing or merging branches. It is all fine 😄

@jywarren
Copy link
Member

jywarren commented Feb 6, 2021

Thanks @vivek-30 and thanks @harshkhandeparkar!

@vivek-30 indeed don't worry, we're here to help!

@jywarren jywarren merged commit f7ca35a into publiclab:main Feb 6, 2021
@jywarren
Copy link
Member

jywarren commented Feb 6, 2021

Great work, thank you very much!!!

@vivek-30
Copy link
Author

vivek-30 commented Feb 7, 2021

Thanks you @jywarren , @harshkhandeparkar you both have helped me out while solving these issues , may be without your help @harshkhandeparkar it becomes difficult to solve this.loved to contribute here ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More General Method of Displaying Docs Links
3 participants