Text Alignment made easy and convenient. #1804

vivek-30 · 2021-02-05T08:47:03Z

Fixes #1767 .
After this fix we can now align text easily at any position on image by just clicking on that point on the image.

gitpod-io · 2021-02-05T08:47:06Z

vivek-30 · 2021-02-05T08:51:34Z

@harshkhandeparkar ,@jywarren could you please review this.

vivek-30 · 2021-02-05T09:06:01Z

This is the working Gif for the mentioned issue -

vivek-30 · 2021-02-05T09:10:49Z

if Gif is hazzy then you can look at this clip -

Screen.Recording.2021-02-05.at.2.04.28.PM.mov

vivek-30 · 2021-02-06T17:51:54Z

@harshkhandeparkar Could you please check this out ☺️

jywarren · 2021-02-06T20:35:08Z

src/modules/TextOverlay/info.json

+        },
+        "custom": {
+            "type": "select",
+            "desc": "Fill Coordinates On Click.",


This is very cool! Could we change this to a button with a crosshairs icon, maybe? What do you think...

https://fontawesome.com/v4.7.0/icon/crosshairs

<i class="fa fa-crosshairs"></i>

Sure ,that will be a better choice

@jywarren please have a look at these new changes

vivek-30 · 2021-02-07T11:57:53Z

This is the working clip with new changes -

Screen.Recording.2021-02-07.at.5.22.52.PM.mov

is this ok now ☺️

daemon1024 · 2021-02-10T13:32:10Z

This is awesome. There's this wierd bug I am facing tho. I need to make some changes in parameters other than the coordinates to make it apply everytime.

jywarren · 2021-02-10T15:19:25Z

Hmm, even if you change the coordinates manually instead of by clicking?

@vivek-30 this looks great. Could you put the button leftmost on the line and use non-bold text that says click to select coordinates on the right side, and place it just above the manual coordinates? Thank you!!!

vivek-30 · 2021-02-10T17:18:04Z

@jywarren , @daemon1024 sir plz have a look now 😊

examples/lib/defaultHtmlStepUi.js

src/modules/TextOverlay/info.json

harshkhandeparkar · 2021-02-10T18:03:29Z

image-sequencer/examples/lib/mapHtmltypes.js

Lines 7 to 28 in eb81b7d

    
           switch(inputInfo.type.toLowerCase()){ 
        
           case 'integer': 
        
             htmlType = inputInfo.min != undefined ? 'range' : 'number'; 
        
             if (htmlType === 'range') inputInfo.step = inputInfo.step || 1; // default range step size for integer 
        
             break; 
        
           case 'string': 
        
             htmlType = 'text'; 
        
             break; 
        
           case 'select': 
        
             htmlType = 'select'; 
        
             break; 
        
           case 'percentage': 
        
             htmlType = 'number'; 
        
             break; 
        
           case 'float': 
        
             htmlType = inputInfo.min != undefined ? 'range' : 'text'; 
        
             if (htmlType === 'range') inputInfo.step = inputInfo.step || 0.1; // default range step size for float 
        
             break; 
        
           default: 
        
             htmlType = 'text'; 
        
             break; 
        
           }

button is not an actual type here. So we can just add coordinate-input as a type ig. What do you think?

vivek-30 · 2021-02-10T18:11:11Z

ok you mean we can add type to be coordinate-input and then create another case in switch statement to handle it accordingly?

harshkhandeparkar · 2021-02-10T18:27:58Z

ok you mean we can add type to be coordinate-input and then create another case in switch statement to handle it accordingly?

Yes. What do you think we should do?

vivek-30 · 2021-02-10T18:38:36Z

sure that will be a better way to handle it 😄 .Thanks for suggesting this.

daemon1024 · 2021-02-10T18:44:44Z

Hmm, even if you change the coordinates manually instead of by clicking?

Nope

Screencast-from-02-11-2021-12_06_28-AM.mp4

As you can see it was not letting me apply changes unless I manually typed in coordinates again or change some other parameter.

daemon1024 · 2021-02-10T18:46:54Z

@vivek-30 It would be great if you commit each of your changes separately instead of amending the original commit would be easy to understand what changes exactly you made after a review/suggestion. Thank You.

harshkhandeparkar · 2021-02-10T18:54:24Z

src/modules/TextOverlay/info.json

@@ -8,6 +8,10 @@
            "desc": "Enter the text to overlay.",
            "default": "Lorem ipsum"
        },
+        "Custom coordinates": {
+            "type": "coordinate-input",
+            "id": "coordinates-input"


id is no longer required :)

Also, please add a description desc if possible.

i have added that but @jywarren wants non-bold text instead.
should i add desc back now?

harshkhandeparkar · 2021-02-10T18:55:17Z

examples/lib/defaultHtmlStepUi.js

@@ -118,7 +118,14 @@ function DefaultHtmlStepUi(_sequencer, options) {
              paramVal + '">' + '<span class="input-group-addon"><i></i></span>' +
              '</div>';
          }
-          else { // Non color-picker input types
+          else if(inputDesc.id === 'coordinates-input'){


You can use inputDesc.type instead of id here.

ok i will remove that.

vivek-30 · 2021-02-10T18:58:06Z

@daemon1024 i thought it will help the maintainers to merge as they themself don't have to do squashing. apologies,😅 now i will take care of this by not amending my commits.

harshkhandeparkar · 2021-02-10T19:11:39Z

@daemon1024 i thought it will help the maintainers to merge as they themself don't have to do squashing. apologies, now i will take care of this by not amending my commits.

Oh, we don't do that. Github does it for us :)

vivek-30 · 2021-02-10T19:21:26Z

@daemon1024 i thought it will help the maintainers to merge as they themself don't have to do squashing. apologies, now i will take care of this by not amending my commits.

Oh, we don't do that. Github does it for us :)

ok i will take care of it ,actually i did not knew about it.

vivek-30 · 2021-02-10T19:42:49Z

sorry for re-pushing this i have accidentally staged and committed some untracked files.

jywarren · 2021-02-11T17:36:11Z

No problem @vivek-30 -- all good, and we really appreciate your work on this! Is it ready for a final review? Thanks!

vivek-30 · 2021-02-14T08:59:15Z

@harshkhandeparkar is there anything else i have to change?

vivek-30 · 2021-02-15T13:11:36Z

@harshkhandeparkar , @jywarren is this PR ready to be merged😅.

jywarren · 2021-02-15T16:46:02Z

Great work, thank you!!!

vivek-30 · 2021-02-15T18:35:34Z

@jywarren welcome sir 😊

vivek-30 requested review from a team as code owners February 5, 2021 08:47

jywarren reviewed Feb 6, 2021

View reviewed changes

vivek-30 force-pushed the text-alignment branch from 4519183 to 891abf7 Compare February 7, 2021 11:20

vivek-30 force-pushed the text-alignment branch 2 times, most recently from 059499c to cc6160c Compare February 7, 2021 15:14

vivek-30 force-pushed the text-alignment branch from 03e02e2 to 900e7eb Compare February 10, 2021 17:13

harshkhandeparkar requested changes Feb 10, 2021

View reviewed changes

examples/lib/defaultHtmlStepUi.js Outdated Show resolved Hide resolved

examples/lib/defaultHtmlStepUi.js Outdated Show resolved Hide resolved

src/modules/TextOverlay/info.json Outdated Show resolved Hide resolved

src/modules/TextOverlay/info.json Outdated Show resolved Hide resolved

text alignment made easy

16d2365

vivek-30 force-pushed the text-alignment branch from 79443ae to 16d2365 Compare February 10, 2021 18:36

harshkhandeparkar requested changes Feb 10, 2021

View reviewed changes

vivek-30 requested a review from a team as a code owner February 10, 2021 19:32

added description and removed id

6b5ac73

vivek-30 force-pushed the text-alignment branch from 1bc7ecd to 6b5ac73 Compare February 10, 2021 19:38

Merge branch 'main' into text-alignment

73d2631

Merge branch 'main' into text-alignment

ac6a740

jywarren merged commit ed94a0f into publiclab:main Feb 15, 2021

vivek-30 deleted the text-alignment branch February 16, 2021 12:42

This was referenced Mar 13, 2021

Write UI test for "click to select coordinates" function #1846

Open

Discussion and Q&A of Outreachy + GSoC ideas 2021 publiclab/plots2#9257

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Text Alignment made easy and convenient. #1804

Text Alignment made easy and convenient. #1804

vivek-30 commented Feb 5, 2021

gitpod-io bot commented Feb 5, 2021 •

edited

Loading

vivek-30 commented Feb 5, 2021

vivek-30 commented Feb 5, 2021

vivek-30 commented Feb 5, 2021

vivek-30 commented Feb 6, 2021

jywarren Feb 6, 2021

vivek-30 Feb 7, 2021

vivek-30 Feb 7, 2021

vivek-30 commented Feb 7, 2021 •

edited

Loading

daemon1024 commented Feb 10, 2021

jywarren commented Feb 10, 2021

vivek-30 commented Feb 10, 2021

harshkhandeparkar commented Feb 10, 2021

vivek-30 commented Feb 10, 2021

harshkhandeparkar commented Feb 10, 2021

vivek-30 commented Feb 10, 2021

daemon1024 commented Feb 10, 2021 •

edited

Loading

daemon1024 commented Feb 10, 2021 •

edited

Loading

harshkhandeparkar Feb 10, 2021

harshkhandeparkar Feb 10, 2021

vivek-30 Feb 10, 2021

harshkhandeparkar Feb 10, 2021

vivek-30 Feb 10, 2021

vivek-30 commented Feb 10, 2021

harshkhandeparkar commented Feb 10, 2021

vivek-30 commented Feb 10, 2021

vivek-30 commented Feb 10, 2021

jywarren commented Feb 11, 2021

vivek-30 commented Feb 14, 2021

vivek-30 commented Feb 15, 2021

jywarren commented Feb 15, 2021

vivek-30 commented Feb 15, 2021

Text Alignment made easy and convenient. #1804

Text Alignment made easy and convenient. #1804

Conversation

vivek-30 commented Feb 5, 2021

gitpod-io bot commented Feb 5, 2021 • edited Loading

vivek-30 commented Feb 5, 2021

vivek-30 commented Feb 5, 2021

vivek-30 commented Feb 5, 2021

vivek-30 commented Feb 6, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vivek-30 commented Feb 7, 2021 • edited Loading

daemon1024 commented Feb 10, 2021

jywarren commented Feb 10, 2021

vivek-30 commented Feb 10, 2021

harshkhandeparkar commented Feb 10, 2021

vivek-30 commented Feb 10, 2021

harshkhandeparkar commented Feb 10, 2021

vivek-30 commented Feb 10, 2021

daemon1024 commented Feb 10, 2021 • edited Loading

daemon1024 commented Feb 10, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vivek-30 commented Feb 10, 2021

harshkhandeparkar commented Feb 10, 2021

vivek-30 commented Feb 10, 2021

vivek-30 commented Feb 10, 2021

jywarren commented Feb 11, 2021

vivek-30 commented Feb 14, 2021

vivek-30 commented Feb 15, 2021

jywarren commented Feb 15, 2021

vivek-30 commented Feb 15, 2021

gitpod-io bot commented Feb 5, 2021 •

edited

Loading

vivek-30 commented Feb 7, 2021 •

edited

Loading

daemon1024 commented Feb 10, 2021 •

edited

Loading

daemon1024 commented Feb 10, 2021 •

edited

Loading