Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardised util functions comments #1805

Merged
merged 5 commits into from Feb 10, 2021
Merged

standardised util functions comments #1805

merged 5 commits into from Feb 10, 2021

Conversation

tanish14
Copy link

@tanish14 tanish14 commented Feb 7, 2021

Fixes #1396 (<=== Replace 0000 with the Issue Number)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm run test-all
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@tanish14 tanish14 requested a review from a team as a code owner February 7, 2021 15:22
@welcome
Copy link

welcome bot commented Feb 7, 2021

Thanks for opening this pull request! This space is protected by our Code of Conduct.
There may be some errors, but don't worry! We're here to help! 👍🎉😄
Also please refer (https://github.com/publiclab/image-sequencer/blob/main/README.md) for installation help.

@gitpod-io
Copy link

gitpod-io bot commented Feb 7, 2021

src/util/pixelSetter.js Outdated Show resolved Hide resolved
src/util/pixelSetter.js Outdated Show resolved Hide resolved
@jywarren jywarren merged commit eb81b7d into publiclab:main Feb 10, 2021
@welcome
Copy link

welcome bot commented Feb 10, 2021

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will be published to https://beta.sequencer.publiclab.org in a day or two. Please test out your work on this testing server and report back with a comment that all has gone well!
In the meantime, can you tell us your Twitter handle so we can thank you properly also do join our weekly check-in to share your this week goal and the awesome work you did 😃.
Please find the link pinned in the issue section
Now that you've completed this, you can help someone else take their first step! Try looking at this list of first-timers-only issues, and see if someone else is waiting for feedback, or even stuck! 😕
People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉
See: Public Lab's coding community!

@jywarren
Copy link
Member

Great work, thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardise Util Functions Comments
3 participants