made update-prompt responsive #1831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@jywarren i know that it is not a big problem to be considered . yet i found it very odd to have on the UI. |
|
thank you i think it makes a lot of sense, much appreciated!
…On Tue, Mar 2, 2021 at 9:59 PM Vivek Singh ***@***.***> wrote:
@jywarren <https://github.com/jywarren> i know that it is not a big
problem to be considered . yet i found it very odd to have on the UI.
i have accidentally found this and thought it needs to be corrected so
please have a look Thank you 😊
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1831 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAF6J2Y2EFIMZCLMAU3J2TTBWQ2PANCNFSM4YQHCYFA>
.
|
jywarren
approved these changes
Mar 3, 2021
|
Welcome and thanks @jywarren sir ,btw i am waiting for my exams to get over so that i can contribute more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed responsiveness of update-prompt.
update-prompt of service worker isn't responsive on smaller screens but After this fix it will be :)