Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update info.json #407 #413

Merged
merged 2 commits into from Oct 16, 2018

Conversation

Projects
None yet
4 participants
@sashadev-sky
Copy link

commented Oct 15, 2018

This is for issue #407

@tech4GT

This comment has been minimized.

Copy link
Member

commented Oct 15, 2018

@sk9331657 please try to comment on the pull request rather than approving or requesting changes, it saves us unnecessary confusion. Thanks!

@tech4GT
Copy link
Member

left a comment

Thanks a lot for the pull request😄
Hmm could you change the message to this
Applies a Gaussian blur given by the intensity value
I think this makes it more clear.

@sk9331657
Copy link

left a comment

LGTM! Keep PR Title and commit message same.

@sk9331657

This comment has been minimized.

Copy link

commented Oct 15, 2018

@tech4GT I will make sure to comment while reviewing next time. 👍

@sashadev-sky

This comment has been minimized.

Copy link
Author

commented Oct 15, 2018

@tech4GT I committed my changes to PR #413

@tech4GT
Copy link
Member

left a comment

This looks great @sashadev-sky I think we are ready to merge here. Thanks!

@jywarren jywarren merged commit 6638e9b into publiclab:main Oct 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.