Button Text Change Done #490
Conversation
|
Thanks for opening this pull request! |
|
@rajcrk please remove
and please swap it with the issue link. |
|
Also it would be cool if you change the text besides the button which reads "press save to see changes". |
| @@ -130,7 +130,7 @@ function DefaultHtmlStepUi(_sequencer, options) { | |||
| $(step.ui.querySelectorAll(".target")).on('change',toggleSaveButton); | |||
|
|
|||
| $(step.ui.querySelector("div.details")).append( | |||
| "<p><button class='btn btn-default btn-save' disabled = 'true' >Save</button><span> Press save to see changes</span></p>" | |||
| "<p><button class='btn btn-default btn-save' disabled = 'true' >Apply</button><span> Press save to see changes</span></p>" | |||
There was a problem hiding this comment.
You can change the text besides the button. That will look better.
|
Great work by the way. You'll have to wait until @publiclab/reviewers review it. |
|
Hi @rajcrk, can you please change the span text as suggested? This is good to go after that... |
|
Hi @rajcrk, just checking if you need any help. Thanks! |
|
These changes have been applied already. Maybe in some other PR. Can this one be closed? @jywarren @gauravano |
|
Thanks @harshkhandeparkar for the status update. Closing this PR as |
Fixes #[Add issue number here.]
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!